Review main Merged

91193[BUGFIX] Avoid using `bool` as `array` in `EXT:indexed_search`

Stefan Bürk CR +2 V +2 Easy +6 −1 updated 10/22/25, 12:14

Commit message

The lexer of `EXT:indexed_search` calls method `getWord()`
in `split2Words()` and expands the result into two
variables using the list syntax `[] = ...`. This
triggers a `PHP Warning` with PHP 8.5.0.

The patch sanitizes the code to check the return array.

  typo3/sysext/indexed_search/Classes/Lexer.php:59
  Cannot use bool as array

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Stefan Bürk uploaded patch set 1 10/22/25, 08:35

  2. core-ci voted on patch set 1 V -1 10/22/25, 09:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87221

  3. Stefan Bürk uploaded patch set 2 V -1 10/22/25, 10:01

  4. core-ci voted on patch set 2 V +1 10/22/25, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87232

  5. Christian Kuhn updated the commit message in patch set 3 V +1 10/22/25, 10:33

  6. Christian Kuhn voted on patch set 3 CR +1 V +1 10/22/25, 10:33

  7. Oliver Klee voted on patch set 3 CR +1 10/22/25, 10:42

  8. core-ci voted on patch set 3 V +1 10/22/25, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87239

  9. Jochen Roth voted on patch set 3 CR +1 V +1 10/22/25, 11:45

  10. Stefan Bürk voted on patch set 3 CR +2 V +2 10/22/25, 12:03

  11. Stefan Bürk merged patch set 4 10/22/25, 12:14