91195[BUGFIX] FalStatus must only check browsable storages
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Johannes Kasberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Johannes Kasberger +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2635
Show 710 earlier messages
-
Markus Klein uploaded patch set 1 10/22/25, 09:17
-
Markus Klein commented on patch set 1 10/22/25, 09:22
-
Oli Bartsch commented on patch set 1 10/22/25, 09:27
FalStatus.php:81ReplyI think it does not make sense to check on non-browsable storages. Might be intended to set them to this state. -
Markus Klein uploaded patch set 2 10/22/25, 09:27
-
core-ci voted on patch set 1 V -1 10/22/25, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87226
-
Markus Klein commented on patch set 2 10/22/25, 09:28
FalStatus.php:81ReplyAcknowledged -
Johannes Kasberger voted on patch set 2 CR +1 V +1 10/22/25, 09:28
-
Markus Klein rebased onto patch set 3
CR +1V +110/22/25, 09:31 -
core-ci voted on patch set 2 V -1 10/22/25, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87227
-
core-ci voted on patch set 3 V -1 10/22/25, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87228
-
Markus Klein commented on patch set 3 10/22/25, 09:48
The reason for the CI failure: > Argument #2 ($values) must be of type array, string given, line 220 -
Markus Klein uploaded patch set 4
V -110/22/25, 09:59 -
Markus Klein uploaded patch set 5 10/22/25, 10:01
-
core-ci voted on patch set 4 V +1 10/22/25, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87231
-
core-ci voted on patch set 5 V +1 10/22/25, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87233
-
Oli Bartsch commented on patch set 5 10/22/25, 10:44
Reply
DoneThis works but I would like to remove v12. This feels like no priority bugfix and chances for regressions are high. -
Markus Klein commented on patch set 5 10/22/25, 10:51
Reply
NO problem with dropping v12 here, but I really disagree on your risk assessment. -
Markus Klein updated the commit message in patch set 6
V +110/22/25, 10:51 -
core-ci voted on patch set 6 V +1 10/22/25, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87242
-
Johannes Kasberger voted on patch set 6 CR +1 V +1 10/22/25, 11:13
-
Stefan Bürk voted on patch set 6 CR +1 10/22/25, 12:17
-
Oli Bartsch commented on patch set 6 V -1 10/22/25, 12:22
Still get the error. Checking. -
Oli Bartsch uploaded patch set 7
CR +1V +110/22/25, 12:30 -
Oli Bartsch commented on patch set 7 10/22/25, 12:30
Reply
Done -
Oli Bartsch voted on patch set 7 CR +1 V +1 10/22/25, 12:32
-
Stefan Bürk voted on patch set 7 CR +1 V +1 10/22/25, 12:35
-
Markus Klein uploaded patch set 8
CR +1V +110/22/25, 12:36 -
Markus Klein commented on patch set 8 V -1 10/22/25, 12:41
updating, once again -
core-ci voted on patch set 7 V +1 10/22/25, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87253
-
Markus Klein uploaded patch set 9
V -110/22/25, 12:44 -
Johannes Kasberger voted on patch set 9 CR +1 V +1 10/22/25, 12:46
-
core-ci voted on patch set 8 V +1 10/22/25, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87257
-
core-ci voted on patch set 9 V +1 10/22/25, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87258
-
Oli Bartsch voted on patch set 9 CR +2 V +2 10/22/25, 13:09
-
Oli Bartsch merged patch set 10 10/22/25, 13:09
FalStatus.php:81