Review main Merged

91195[BUGFIX] FalStatus must only check browsable storages

Markus Klein CR +2 V +2 Easy +23 −18 updated 10/22/25, 13:09

Commit message

The selection of storages to validate previously only
considered the "online"-status of a storage.
But, any storage may be online, but not browsable.

Since the FalStatus check is about the files
inside the storage, it does not make sense
(and actually fails) to check non-browsable storages.

Ensure only browsable storages are considered for this
status report.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Johannes Kasberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Johannes Kasberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2635

Show 710 earlier messages
  1. Markus Klein uploaded patch set 1 10/22/25, 09:17

  2. Markus Klein commented on patch set 1 10/22/25, 09:22

    FalStatus.php:81

    It can be questioned if this check should still be done on non-browsable storages. but I think it's highly unlikely that missing files occur there
  3. Oli Bartsch commented on patch set 1 10/22/25, 09:27

    FalStatus.php:81 Reply

    I think it does not make sense to check on non-browsable storages. Might be intended to set them to this state.
  4. Markus Klein uploaded patch set 2 10/22/25, 09:27

  5. core-ci voted on patch set 1 V -1 10/22/25, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87226

  6. Markus Klein commented on patch set 2 10/22/25, 09:28

    FalStatus.php:81 Reply

    Acknowledged
  7. Johannes Kasberger voted on patch set 2 CR +1 V +1 10/22/25, 09:28

  8. Markus Klein rebased onto patch set 3 CR +1 V +1 10/22/25, 09:31

  9. core-ci voted on patch set 2 V -1 10/22/25, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87227

  10. core-ci voted on patch set 3 V -1 10/22/25, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87228

  1. Markus Klein commented on patch set 3 10/22/25, 09:48

    The reason for the CI failure: > Argument #2 ($values) must be of type array, string given, line 220
  2. Markus Klein uploaded patch set 4 V -1 10/22/25, 09:59

  3. Markus Klein uploaded patch set 5 10/22/25, 10:01

  4. core-ci voted on patch set 4 V +1 10/22/25, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87231

  5. core-ci voted on patch set 5 V +1 10/22/25, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87233

  6. Oli Bartsch commented on patch set 5 10/22/25, 10:44

    Reply

    Done
    This works but I would like to remove v12. This feels like no priority bugfix and chances for regressions are high.
  7. Markus Klein commented on patch set 5 10/22/25, 10:51

    Reply

    NO problem with dropping v12 here, but I really disagree on your risk assessment.
  8. Markus Klein updated the commit message in patch set 6 V +1 10/22/25, 10:51

  9. core-ci voted on patch set 6 V +1 10/22/25, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87242

  10. Johannes Kasberger voted on patch set 6 CR +1 V +1 10/22/25, 11:13

  11. Stefan Bürk voted on patch set 6 CR +1 10/22/25, 12:17

  12. Oli Bartsch commented on patch set 6 V -1 10/22/25, 12:22

    Still get the error. Checking.
  13. Oli Bartsch uploaded patch set 7 CR +1 V +1 10/22/25, 12:30

  14. Oli Bartsch commented on patch set 7 10/22/25, 12:30

    Reply

    Done
  15. Oli Bartsch voted on patch set 7 CR +1 V +1 10/22/25, 12:32

  16. Stefan Bürk voted on patch set 7 CR +1 V +1 10/22/25, 12:35

  17. Markus Klein uploaded patch set 8 CR +1 V +1 10/22/25, 12:36

  18. Markus Klein commented on patch set 8 V -1 10/22/25, 12:41

    updating, once again
  19. core-ci voted on patch set 7 V +1 10/22/25, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87253

  20. Markus Klein uploaded patch set 9 V -1 10/22/25, 12:44

  21. Johannes Kasberger voted on patch set 9 CR +1 V +1 10/22/25, 12:46

  22. core-ci voted on patch set 8 V +1 10/22/25, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87257

  23. core-ci voted on patch set 9 V +1 10/22/25, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87258

  24. Oli Bartsch voted on patch set 9 CR +2 V +2 10/22/25, 13:09

  25. Oli Bartsch merged patch set 10 10/22/25, 13:09