Review main Merged

91220[TASK] Improve line height for links in login screen

Vladimir Falcón Piva CR +2 V +2 Easy +5 −0 updated 10/23/25, 19:21

Commit message

Adjust the line height of the link elements to ensure enough
whitespace between the links to improve accessibility.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Sven Liebert +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1113

  1. Vladimir Falcón Piva uploaded patch set 1 10/23/25, 09:19

  2. core-ci voted on patch set 1 V +1 10/23/25, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87393

  3. Marno Schmigotzki voted on patch set 1 CR +1 V +1 10/23/25, 09:27

  4. Markus Timtner voted on patch set 1 CR +1 10/23/25, 10:30

  5. Markus Timtner voted on patch set 1 V +1 10/23/25, 10:30

  6. Benjamin Franzke wrote 10/23/25, 10:54

    Hashtag added: tas2025
  7. Benjamin Franzke commented on patch set 1 V -1 10/23/25, 11:06

    _login_screen.scss:271

    From https://www.w3.org/WAI/WCAG22/Understanding/target-size-minimum.html > Undersized targets (those less than 24 by 24 CSS pixels) are positioned so that if a 24 CSS pixel diameter circle is centered on the bounding box of each, the circles do not intersect another target or the circle for another undersized target. The links are undersizes, that means each virtual 24 px diameter circle needs not to overlap with the other elements. In my tests that means we need a line-height of 2.25 here, 1.75 does suffice. Can be tested via custom CSS: ``` list-unstyled li { position: relative; } .list-unstyled li::before { content: ''; display: block; position: absolute; left: 33px; top: 50%; height: 24px; width: 24px; background: #ff0000aa; border-radius: 50%; transform: translateY(-50%); } ```
  8. Benjamin Franzke uploaded patch set 2 CR +1 V +1 10/23/25, 11:07

  9. Benjamin Franzke commented on patch set 2 10/23/25, 11:07

    _login_screen.scss:271 Reply

    Done
  10. core-ci voted on patch set 2 V +1 10/23/25, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87405

  11. Sven Liebert voted on patch set 2 CR +1 V +1 10/23/25, 16:38

  12. Benjamin Franzke voted on patch set 2 CR +2 V +2 10/23/25, 17:31

  13. Benjamin Franzke merged patch set 3 10/23/25, 19:21