Review main Merged

91221[TASK] Add ARIA role "alert" to login error message

René Pflamm CR +2 V +2 Easy +1 −1 updated 10/23/25, 19:33

Commit message

Improve accessibility for the login screen by adding the `role="alert"`
attribute for error messages, to ensure that the text is read aloud
automatically by screenreaders.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • René Pflamm +1
    • Markus Timtner +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Markus Timtner +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. René Pflamm uploaded patch set 1 10/23/25, 10:06

  2. core-ci voted on patch set 1 V +1 10/23/25, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87399

  3. Markus Timtner voted on patch set 1 V +1 10/23/25, 10:31

  4. Markus Timtner voted on patch set 1 CR +1 10/23/25, 10:31

  5. Benjamin Franzke wrote 10/23/25, 10:54

    Hashtag added: tas2025
  6. Benjamin Franzke uploaded patch set 2 CR +1 V +1 10/23/25, 11:21

  7. core-ci voted on patch set 2 V +1 10/23/25, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87411

  8. Markus Timtner voted on patch set 2 CR +1 10/23/25, 13:54

  9. Markus Timtner voted on patch set 2 V +1 10/23/25, 13:54

  10. René Pflamm voted on patch set 2 CR +1 10/23/25, 16:14

  11. Sven Liebert voted on patch set 2 CR +1 V +1 10/23/25, 16:37

  12. Benjamin Franzke commented on patch set 2 CR +2 V +2 10/23/25, 19:33

    Tested with NVDA, Narrator and VoiceOver.
  13. Benjamin Franzke merged patch set 3 10/23/25, 19:33