Review main Merged

9124[FEATURE] RTE: Use HTML5-compliant custom attribute for external url's

Stanislas Rolland CR +2 V +2 Easy +15 −15 updated 06/03/13, 20:49

Commit message

htmlArea RTE sets custom attribute "external" on links to external
url's so that they are preserved as external by the RTE
transformation, even though they may look internal.

Use custom attribute "data-htmlarea-external" instead in order to be
HTML5-compliant.

Review

  • Code review CR +2
    • Stanislas Rolland +2
    • Wouter Wolters +1
    • Tolleiv Nietsch +1
    • Steffen Ritter +1
  • Verified V +2
    • Stanislas Rolland +2
    • Wouter Wolters +1
    • Tolleiv Nietsch +1

Issues 1

Files 3

Review log 13

  1. Mr. Jenkins commented on patch set 1 02/27/12, 17:07

  2. Stanislas Rolland commented on patch set 2 V 0 02/27/12, 17:07

    by team member; Looks good to me, approved
  3. Stanislas Rolland commented on patch set 2 02/27/12, 17:07

    @Tolleiv: not really. Due to the transformation, the custom attribute should never make his way into the database.
  4. Stanislas Rolland commented on patch set 2 02/27/12, 17:07

    @Steffen: No it does not matter. The "external" attribute never goes into the database. It is unset before. If it somehow got into the database, it is simply ignored by the transform. When appropriate, the attribute "data-htmlarea-external" will be set on the way to the RTE, just like "external" was.
  5. Tolleiv Nietsch commented on patch set 2 02/27/12, 17:07

    Verified; Looks good to me, but someone else must approve right - worked fine for me ... Steffen would be great if you could confirm too?
  6. Tolleiv Nietsch commented on patch set 2 02/27/12, 17:07

    I would prefer that you didn't submit this This should come with an upgrade wizard, right?
  7. Steffen Ritter commented on patch set 2 02/27/12, 17:07

    Looks good to me, but someone else must approve
  8. Steffen Ritter commented on patch set 2 02/27/12, 17:07

    what if the old attribute is still in database? does that harm when re-editing?
  9. Steffen Ritter commented on patch set 2 02/27/12, 17:07

    yeah with Stans explanation, fine with me
  10. Mr. Jenkins commented on patch set 2 02/27/12, 17:07

  11. Wouter Wolters uploaded patch set 2 02/27/12, 17:07

  12. Wouter Wolters commented on patch set 2 02/27/12, 17:07

    Verified; Looks good to me, but someone else must approve Only fixed the commit message.
  13. Stanislas Rolland merged patch set 2 02/27/12, 17:07