Review main Merged

91249[TASK] Inline property in DefaultJavaScriptAssetTrait

Christian Kuhn CR +2 V +2 Easy +1 −2 updated 10/25/25, 09:22

Commit message

Properties in traits in PHP are kinda problematic: Trait
consumers can not declare a property to a different value,
it results in a "the definition differs and is considered
incompatible" error.

DefaultJavaScriptAssetTrait can be easily changed by
inlining a property to avoid this issue. This also
allows declaring consumers readonly.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Christian Kuhn uploaded patch set 1 10/25/25, 02:22

  2. Christian Kuhn updated the commit message in patch set 2 10/25/25, 02:23

  3. core-ci voted on patch set 1 V +1 10/25/25, 02:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87547

  4. core-ci voted on patch set 2 V +1 10/25/25, 02:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87548

  5. Oliver Klee voted on patch set 2 CR +1 V +1 10/25/25, 07:38

  6. Oli Bartsch voted on patch set 2 CR +2 V +2 10/25/25, 09:22

  7. Oli Bartsch merged patch set 3 10/25/25, 09:22