Review 13.4 Merged

91331[BUGFIX] Do not add cache busting to folders

Helmut Hummel CR +2 V +2 Easy +4 −1 updated 10/29/25, 15:47

Commit message

It might be useful to generate URIs for folders,
but them having cache busting applied does not make
sense and is buggy.

Therefore the check for file existence must be changed
from file_exists to is_file, as the latter only returns
true it the referenced path is a file (or a symlink to a file)

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Simon Praetorius +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Helmut Hummel uploaded patch set 1 10/29/25, 12:25

  2. Helmut Hummel rebased onto patch set 2 10/29/25, 12:25

  3. Simon Praetorius voted on patch set 2 CR +1 V +1 10/29/25, 12:27

  4. core-ci voted on patch set 1 V +1 10/29/25, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87960

  5. core-ci voted on patch set 2 V +1 10/29/25, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87961

  6. Helmut Hummel voted on patch set 2 CR +2 V +2 10/29/25, 15:46

  7. Helmut Hummel merged patch set 3 10/29/25, 15:47