9136[FEATURE] Checkbox for confirmation in FormWizard
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Stefan Neufeind +1
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Stefan Neufeind +1
Issues 1
Files 5
- typo3/sysext/form/Classes/View/Wizard/WizardView.php+1 −0
- typo3/sysext/form/Configuration/PageTS/modWizards.ts+1 −1
- typo3/sysext/form/Resources/Private/Language/locallang_wizard.xlf+6 −0
- typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Form/Behaviour.js3new+128 −0
- typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Form.js+13 −0
Review log 30
Show 5 earlier messages
-
Stefan Neufeind commented on patch set 1 03/31/13, 20:09
Looks good to me, but someone else must approveReleases: 6.0Behaviour.js:32move this one row further down?Behaviour.js:92it's been argued whether CGL applies to JS as well. But should we maybe just remove one tab for the comment here here (same below)? -
Christian Kuhn commented on patch set 1 03/31/13, 20:09
I've asked Patrick for a review. Maybe he finds some time. -
Anja Leichsenring commented on patch set 1 03/31/13, 20:09
Verified; Looks good to me, but someone else must approve -
Anja Leichsenring commented on patch set 1 03/31/13, 20:09
No score; No score @Florian: Review and test the patch, improve it if neccessary, and it will be merged. -
Anja Leichsenring commented on patch set 1 03/31/13, 20:09
Verified; Looks good to me, but someone else must approve
-
Anja Leichsenring commented on patch set 1 03/31/13, 20:09
Fails rebase needed -
Mr. Jenkins commented on patch set 1 03/31/13, 20:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3354/ : SUCCESS -
Wouter Wolters commented on patch set 1 03/31/13, 20:09
Looks good to me, but someone else must approve -
Florian Scholz commented on patch set 1 03/31/13, 20:09
Could someone please review these bits? -
Florian Scholz commented on patch set 1 03/31/13, 20:09
Bump! -
Florian Scholz commented on patch set 1 03/31/13, 20:09
This is going to take forever, eh? BUMP! -
Stefan Neufeind commented on patch set 2 03/31/13, 20:09
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 3 2 comments 03/31/13, 20:09
Looks good to me, but someone else must approve by reading only found nitpicks -
Stefan Neufeind voted on patch set 3 V 0 03/31/13, 20:09
-
Markus Klein uploaded patch set 3 03/31/13, 20:09
-
Markus Klein commented on patch set 3 03/31/13, 20:09
Rebased for current master -
Oliver Klee commented on patch set 3 03/31/13, 20:09
(1 inline comment)Behaviour.js:120There's no matching parameter for this @param. -
Oliver Hader commented on patch set 3 03/31/13, 20:09
Looks good to me, but someone else must approve Will test later today. Looks good from reading though... -
Stefan Neufeind commented on patch set 4 03/31/13, 20:09
Verified; Looks good to me, but someone else must approve -
Christian Kuhn uploaded patch set 4 03/31/13, 20:09
-
Christian Kuhn commented on patch set 4 03/31/13, 20:09
Verified; Looks good to me, but someone else must approve -
Anja Leichsenring commented on patch set 2 03/31/13, 20:09
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 2 03/31/13, 20:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6763/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/31/13, 20:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7465/ : SUCCESS -
Mr. Jenkins commented on patch set 4 03/31/13, 20:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8058/ : SUCCESS -
Wouter Wolters commented on patch set 4 03/31/13, 20:09
Looks good to me, but someone else must approve -
Florian Scholz commented on patch set 2 03/31/13, 20:09
Friendly review ping. I don't want this to get bit-rotted again. Thanks! -
Florian Scholz uploaded patch set 2 03/31/13, 20:09
-
Christian Kuhn commented on patch set 4 V 0 03/31/13, 20:09
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 5 03/31/13, 20:09