Review main Merged

9136[FEATURE] Checkbox for confirmation in FormWizard

Florian Scholz CR +2 V +2 Normal +149 −1 updated 06/03/13, 20:49

Commit message

Adds an extra BEHAVIOUR section to form tab with a
checkbox to control whether the confirmation page
should be shown.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Stefan Neufeind +1

Issues 1

Files 5

Review log 30

Show 5 earlier messages
  1. Stefan Neufeind commented on patch set 1 03/31/13, 20:09

    Looks good to me, but someone else must approve
    Releases: 6.0

    Behaviour.js:32

    move this one row further down?

    Behaviour.js:92

    it's been argued whether CGL applies to JS as well. But should we maybe just remove one tab for the comment here here (same below)?
  2. Christian Kuhn commented on patch set 1 03/31/13, 20:09

    I've asked Patrick for a review. Maybe he finds some time.
  3. Anja Leichsenring commented on patch set 1 03/31/13, 20:09

    Verified; Looks good to me, but someone else must approve
  4. Anja Leichsenring commented on patch set 1 03/31/13, 20:09

    No score; No score @Florian: Review and test the patch, improve it if neccessary, and it will be merged.
  5. Anja Leichsenring commented on patch set 1 03/31/13, 20:09

    Verified; Looks good to me, but someone else must approve
  1. Anja Leichsenring commented on patch set 1 03/31/13, 20:09

    Fails rebase needed
  2. Mr. Jenkins commented on patch set 1 03/31/13, 20:09

  3. Wouter Wolters commented on patch set 1 03/31/13, 20:09

    Looks good to me, but someone else must approve
  4. Florian Scholz commented on patch set 1 03/31/13, 20:09

    Could someone please review these bits?
  5. Florian Scholz commented on patch set 1 03/31/13, 20:09

    Bump!
  6. Florian Scholz commented on patch set 1 03/31/13, 20:09

    This is going to take forever, eh? BUMP!
  7. Stefan Neufeind commented on patch set 2 03/31/13, 20:09

    Looks good to me, but someone else must approve
  8. Stefan Neufeind commented on patch set 3 2 comments 03/31/13, 20:09

    Looks good to me, but someone else must approve by reading only found nitpicks
  9. Stefan Neufeind voted on patch set 3 V 0 03/31/13, 20:09

  10. Markus Klein uploaded patch set 3 03/31/13, 20:09

  11. Markus Klein commented on patch set 3 03/31/13, 20:09

    Rebased for current master
  12. Oliver Klee commented on patch set 3 03/31/13, 20:09

    (1 inline comment)

    Behaviour.js:120

    There's no matching parameter for this @param.
  13. Oliver Hader commented on patch set 3 03/31/13, 20:09

    Looks good to me, but someone else must approve Will test later today. Looks good from reading though...
  14. Stefan Neufeind commented on patch set 4 03/31/13, 20:09

    Verified; Looks good to me, but someone else must approve
  15. Christian Kuhn uploaded patch set 4 03/31/13, 20:09

  16. Christian Kuhn commented on patch set 4 03/31/13, 20:09

    Verified; Looks good to me, but someone else must approve
  17. Anja Leichsenring commented on patch set 2 03/31/13, 20:09

    Verified; Looks good to me, but someone else must approve
  18. Mr. Jenkins commented on patch set 2 03/31/13, 20:09

  19. Mr. Jenkins commented on patch set 3 03/31/13, 20:09

  20. Mr. Jenkins commented on patch set 4 03/31/13, 20:09

  21. Wouter Wolters commented on patch set 4 03/31/13, 20:09

    Looks good to me, but someone else must approve
  22. Florian Scholz commented on patch set 2 03/31/13, 20:09

    Friendly review ping. I don't want this to get bit-rotted again. Thanks!
  23. Florian Scholz uploaded patch set 2 03/31/13, 20:09

  24. Christian Kuhn commented on patch set 4 V 0 03/31/13, 20:09

    by team member; Looks good to me, approved
  25. Christian Kuhn merged patch set 5 03/31/13, 20:09