Review main Abandoned

9143[BUGFIX] Error in Crop Parameter for ImageMagick convert

Mario Rimann CR 0 V 0 Easy +2 −2 updated 03/14/15, 19:26

Commit message

This change ensures that the parameters for the crop command
are either both positive or both negative, but never a positive and
a negative value together.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 27

Show 2 earlier messages
  1. Mario Rimann commented on patch set 1 05/27/13, 17:19

    I've just prepared the patch and pushed it to Gerrit. I had no chance to verify the functionality, so this will need someone to clearly test it!
  2. Markus Klein uploaded patch set 2 05/27/13, 17:19

  1. Markus Klein commented on patch set 2 05/27/13, 17:19

    Just some CGL fixes.
  2. Stefan Neufeind commented on patch set 4 05/27/13, 17:19

    Looks good to me, but someone else must approve
    and 6.1
  3. Marcus Schwemer uploaded patch set 4 05/27/13, 17:19

  4. Marcus Schwemer commented on patch set 4 05/27/13, 17:19

    Looks good to me, but someone else must approve Updated commit message, since it is still valid on the current (6.0) master branch
  5. Markus Klein uploaded patch set 3 05/27/13, 17:19

  6. Mario Rimann uploaded patch set 6 05/27/13, 17:19

  7. Stefan Neufeind commented on patch set 5 05/27/13, 17:19

    (1 inline comment)
  8. Markus Klein uploaded patch set 5 05/27/13, 17:19

  9. Markus Klein commented on patch set 5 05/27/13, 17:19

    Looks good to me, but someone else must approve rebased
  10. Markus Klein commented on patch set 5 05/27/13, 17:19

    Florian, can you confirm that this patch is working on a production system?
  11. Markus Klein commented on patch set 6 05/27/13, 17:19

    Looks good to me, but someone else must approve Florian, can you confirm that this patch is working on a production system?
  12. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  13. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  14. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  15. Mr. Jenkins commented on patch set 5 05/27/13, 17:19

  16. Mr. Jenkins commented on patch set 6 05/27/13, 17:19

  17. Wouter Wolters commented on patch set 5 05/27/13, 17:19

    Looks good to me, but someone else must approve
  18. Markus Klein uploaded patch set 7 06/04/13, 22:39

  19. Markus Klein commented on patch set 7 CR +1 06/04/13, 22:40

    Rebased and added 6.2
  20. Stefan Neufeind voted on patch set 7 CR +1 06/05/13, 06:30

  21. Philipp Gampe commented on patch set 7 V -1 CR -1 06/22/13, 23:03

    Do not get the code. Consider this example: page.100 = IMAGE page.100 { file = GIFBUILDER file { 10 = TEXT 10 { offset = 10,20 text = Foo } 20 = CROP 20.crop = 10,10,20,15 } } That works. If I change the sign of any parameter of both, then PHP issues errors (visible in admin panel).
  22. Anja Leichsenring updated the commit message in patch set 8 12/13/14, 14:21

  23. Anja Leichsenring commented on patch set 8 CR -1 12/13/14, 14:22

    only commit message updated, I repeat the negative vote from Phillip. Please verify.
  24. Mathias Schreiber wrote 12/14/14, 16:10

    Topic changed from 33728 to Image API
  25. Markus Klein abandoned the change 03/14/15, 19:26

    No progress for 2 years, no more complaints about this error and this patch does not work according to reviews.