91434[BUGFIX] Avoid undefined array key access in DependencyOrderingService
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1827
Show 2 earlier messages
-
Sebastien Convers updated the commit message in patch set 3 11/06/25, 14:13
-
core-ci voted on patch set 1 V +1 11/06/25, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88579
-
Stefan Bürk updated the commit message in patch set 4 11/06/25, 14:18
-
core-ci voted on patch set 2 V +1 11/06/25, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88580
-
core-ci voted on patch set 3 V +1 11/06/25, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88581
-
core-ci voted on patch set 4 V +1 11/06/25, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88582
-
Stefan Bürk updated the commit message in patch set 5
V +111/06/25, 14:27 -
core-ci voted on patch set 5 V +1 11/06/25, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88583
-
Josef Glatz updated the commit message in patch set 6
V +111/06/25, 18:52 -
core-ci voted on patch set 6 V +1 11/06/25, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88599
-
Stefan Bürk updated the commit message in patch set 7
V +111/18/25, 08:23 -
Stefan Bürk updated the commit message in patch set 8 11/18/25, 08:24
-
core-ci voted on patch set 7 V +1 11/18/25, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89999
-
core-ci voted on patch set 8 V +1 11/18/25, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90000
-
Oliver Klee voted on patch set 8 CR +1 11/18/25, 09:09
-
Garvin Hicking voted on patch set 8 CR +1 11/18/25, 09:35
-
Christian Kuhn commented on patch set 8 11/18/25, 11:25
any chance to add a covering unit test for this one? this should be do-able by looking at the subject, and this class is quite critical. -
Sebastien Convers commented on patch set 8 11/25/25, 13:13
Reply
I'd like to make it, but i don't know how/what to test. Could you point me to something similar i could use as inspiration? -
Christian Kuhn commented on patch set 8 12/12/25, 13:01
Reply
ok. let's get this done. sorry for the delay. i hope it is ok to chime in and push. i was unable to actually reproduce the site sets related scenario. but i was able to add a unit test for calculateOrder() that fails when the change is not applied. i slightly cleanup the tests up along the way. i think it's fine to bring this in now: wo don't add coverage for all changes, but the code changes itself are non-risky. -
Christian Kuhn uploaded patch set 9
CR +1V +112/12/25, 13:02 -
Christian Kuhn voted on patch set 9 CR +1 V +1 12/12/25, 13:04
-
Oliver Klee voted on patch set 9 CR +1 V +1 12/12/25, 13:06
-
core-ci voted on patch set 9 V +1 12/12/25, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92143
-
Christian Kuhn voted on patch set 9 CR +2 V +2 12/12/25, 13:23
-
Christian Kuhn merged patch set 10 12/12/25, 13:31