Review main Merged

91536[BUGFIX] Check if storage exists when fetching object

Christian Weiske CR +2 V +2 Easy +3 −0 updated 11/11/25, 22:56

Commit message

When editing a sys_filemount record that has its identifier set
to a non-existing storage, TYPO3 crashed with
> Call to a member function hasFile() on null
> in .../core/Classes/Resource/ResourceFactory.php line 350
> at ResourceFactory->getObjectFromCombinedIdentifier()

This patch checks if the storage object is valid, and throws
a proper exception when not.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Weiske uploaded patch set 1 11/11/25, 09:20

  2. core-ci voted on patch set 1 V +1 11/11/25, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88965

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 11/11/25, 22:30

    Thanks! 😊
  4. Georg Ringer voted on patch set 1 CR +1 V +1 11/11/25, 22:40

  5. Garvin Hicking voted on patch set 1 CR +2 V +2 11/11/25, 22:49

  6. Garvin Hicking merged patch set 2 11/11/25, 22:56