9170[BUGFIX] Images from TER hosters break SSL
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Georg Ringer +1
- Oliver Klee +1
- Tolleiv Nietsch +1
- Wouter Wolters +1
-
Verified V +2
- Steffen Ritter +2
- Georg Ringer +1
- Tolleiv Nietsch +1
Files 1
Review log 18
-
Tolleiv Nietsch commented on patch set 1 03/07/12, 07:21
Removing the "http:" would imho be enough... (leaving "//domain.tld/") -
Tolleiv Nietsch uploaded patch set 3 03/07/12, 07:21
-
Tolleiv Nietsch commented on patch set 3 03/07/12, 07:21
Verified; Looks good to me, but someone else must approve 4.8 / 6.0 is what we get from current master, so we've to include that as well... ;) -
Oliver Klee commented on patch set 3 03/07/12, 07:21
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 2 03/07/12, 07:21
those images come all from typo3.org! -
Georg Ringer uploaded patch set 2 03/07/12, 07:21
-
Georg Ringer commented on patch set 3 1 comment 03/07/12, 07:21
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 1 03/07/12, 07:21
Looks good to me, but someone else must approve Well, I think this does not really matter ... does it? -
Philipp Gampe commented on patch set 2 03/07/12, 07:21
Can we be sure that all TER mirrors over SSL? 4.8 is missing in the release line -
Philipp Gampe commented on patch set 2 03/07/12, 07:21
Looks good to me, but someone else must approve Ah ok, thanks. -
Philipp Gampe commented on patch set 2 03/07/12, 07:21
Arg, then sentence should read: Can we be sure that all TER mirrors offer SSL? -
Mr. Jenkins commented on patch set 1 03/07/12, 07:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3377/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/07/12, 07:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3512/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/07/12, 07:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3523/ : SUCCESS -
Wouter Wolters commented on patch set 3 03/07/12, 07:21
Looks good to me, but someone else must approve One comment, can be changed on commit I guessIf I read the patch correctly this case here isn't correct, because now only http is used.Logo's aren't fetched in the same context then as the backend, or am I wrong here? -
Wouter Wolters commented on patch set 3 03/07/12, 07:21
(1 inline comment) -
Steffen Ritter commented on patch set 3 V 0 03/07/12, 07:21
by team member; Looks good to me, approved -
Steffen Ritter merged patch set 3 03/07/12, 07:21