Review main Merged

9170[BUGFIX] Images from TER hosters break SSL

Georg Ringer CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

The logos should be fetched in the same context as the backend.
If https is used there, images are now loaded also via https

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Tolleiv Nietsch +1
    • Wouter Wolters +1
  • Verified V +2
    • Steffen Ritter +2
    • Georg Ringer +1
    • Tolleiv Nietsch +1

Files 1

Review log 18

  1. Tolleiv Nietsch commented on patch set 1 03/07/12, 07:21

    Removing the "http:" would imho be enough... (leaving "//domain.tld/")
  2. Tolleiv Nietsch uploaded patch set 3 03/07/12, 07:21

  3. Tolleiv Nietsch commented on patch set 3 03/07/12, 07:21

    Verified; Looks good to me, but someone else must approve 4.8 / 6.0 is what we get from current master, so we've to include that as well... ;)
  4. Oliver Klee commented on patch set 3 03/07/12, 07:21

    Looks good to me, but someone else must approve
  5. Georg Ringer commented on patch set 2 03/07/12, 07:21

    those images come all from typo3.org!
  6. Georg Ringer uploaded patch set 2 03/07/12, 07:21

  7. Georg Ringer commented on patch set 3 1 comment 03/07/12, 07:21

    Verified; Looks good to me, but someone else must approve
  8. Philipp Gampe commented on patch set 1 03/07/12, 07:21

    Looks good to me, but someone else must approve Well, I think this does not really matter ... does it?
  9. Philipp Gampe commented on patch set 2 03/07/12, 07:21

    Can we be sure that all TER mirrors over SSL? 4.8 is missing in the release line
  10. Philipp Gampe commented on patch set 2 03/07/12, 07:21

    Looks good to me, but someone else must approve Ah ok, thanks.
  11. Philipp Gampe commented on patch set 2 03/07/12, 07:21

    Arg, then sentence should read: Can we be sure that all TER mirrors offer SSL?
  12. Mr. Jenkins commented on patch set 1 03/07/12, 07:21

  13. Mr. Jenkins commented on patch set 2 03/07/12, 07:21

  14. Mr. Jenkins commented on patch set 3 03/07/12, 07:21

  15. Wouter Wolters commented on patch set 3 03/07/12, 07:21

    Looks good to me, but someone else must approve One comment, can be changed on commit I guess
    If I read the patch correctly this case here isn't correct, because now only http is used.
    Logo's aren't fetched in the same context then as the backend, or am I wrong here?
  16. Wouter Wolters commented on patch set 3 03/07/12, 07:21

    (1 inline comment)
  17. Steffen Ritter commented on patch set 3 V 0 03/07/12, 07:21

    by team member; Looks good to me, approved
  18. Steffen Ritter merged patch set 3 03/07/12, 07:21