Review main Merged

91995[BUGFIX] RTE: Allow partial selection when clicking into links

Philipp Kitzberger CR +2 V +2 Easy +2 −6 updated 12/07/25, 00:18

Commit message

Clicking into a link element was automatically expanding the selection
to encompass the entire link, preventing users from selecting or
editing fractions of the link content such as icons or individual words.

The expandSelectionToFullLink() call has been removed from showUI(),
as it interfered with normal editing behavior when clicking into links.
The full link expansion is still preserved in openLinkBrowser(), where
it's needed to prevent link splitting when modifying link attributes
through the link browser dialog.

This restores the ability to work with partial selections within links
while maintaining protection against unintended link splitting during
link attribute editing.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Philipp Kitzberger uploaded patch set 1 12/03/25, 11:32

  2. core-ci voted on patch set 1 V +1 12/03/25, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91520

  3. Garvin Hicking updated the commit message in patch set 2 V +1 12/03/25, 12:08

  4. core-ci voted on patch set 2 V +1 12/03/25, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91528

  5. Garvin Hicking commented on patch set 2 CR +1 V +1 12/05/25, 14:41

    Now I could wrap my head around this link ;) Patch works and I understand the situation (note that you could use the keyboard keys to navigate the cursor within the link despite the current flaw).
  6. Andreas Nedbal voted on patch set 2 CR +1 V +1 12/05/25, 15:04

  7. Garvin Hicking voted on patch set 2 CR +2 V +2 12/07/25, 00:17

  8. Garvin Hicking merged patch set 3 12/07/25, 00:18