Review main Merged

92096[TASK] Rename SystemInformationController to EventListener and modernize class

Simon Schaufelberger CR +2 V +2 Easy +18 −12 updated 12/11/25, 16:43

Commit message

The class SystemInformationController had the misleading suffix
Controller, but it wasn't a controller. The new suffix EventListener
makes it clear which type of class it actually is.

Additionally, DI is used and new translation mechanisms applied.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Lina Wolf +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Lina Wolf +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2024

  1. Simon Schaufelberger uploaded patch set 1 12/10/25, 21:45

  2. core-ci voted on patch set 1 V +1 12/10/25, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92023

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 12/10/25, 22:30

  4. Lina Wolf commented on patch set 1 CR +1 V +1 12/11/25, 05:50

    My fingers where actually itching to do the same just yesterday ;)
  5. Torben Hansen voted on patch set 1 CR +1 V +1 12/11/25, 09:55

  6. Benni Mack commented on patch set 1 12/11/25, 10:13

    SystemInformationEventListener.php:70

    if you go with DI, you could also use the UriBuilder to inject as well :)
  7. Simon Schaufelberger commented on patch set 1 12/11/25, 10:34

    SystemInformationEventListener.php:70 Reply

    I was thinking about that but the UriBuilder has state and I wasn't sure if this could lead to side effects
  8. Benni Mack uploaded patch set 2 CR +1 V +1 12/11/25, 10:48

  9. Simon Schaufelberger commented on patch set 2 CR +1 V +1 12/11/25, 10:50

    SystemInformationEventListener.php:70 Reply

    Done
  10. core-ci voted on patch set 2 V +1 12/11/25, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92058

  11. Lina Wolf commented on patch set 2 12/11/25, 11:05

    SystemInformationEventListener.php:75

    ```suggestion 'belog.messages', ```
  12. Simon Schaufelberger commented on patch set 3 CR +1 V +1 12/11/25, 11:13

    Published edit on patch set 2.
  13. Simon Schaufelberger commented on patch set 3 12/11/25, 11:13

    SystemInformationEventListener.php:75 Reply

    Fix applied.
  14. core-ci voted on patch set 3 V +1 12/11/25, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92061

  15. Lina Wolf commented on patch set 3 CR +1 V +1 12/11/25, 11:28

    Count is displayed correctly in the system menu
  16. Simon Schaufelberger voted on patch set 3 CR +1 V +1 12/11/25, 11:46

  17. Garvin Hicking updated the commit message in patch set 4 CR +1 V +1 12/11/25, 12:01

  18. Lina Wolf voted on patch set 4 CR +1 V +1 12/11/25, 12:07

  19. core-ci voted on patch set 4 V +1 12/11/25, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92065

  20. Simon Schaufelberger voted on patch set 4 CR +1 V +1 12/11/25, 12:44

  21. Christian Kuhn commented on patch set 4 12/11/25, 15:47

    SystemInformationEventListener.php:70 Reply

    yeah. that's why i didn't do that, too.
  22. Christian Kuhn commented on patch set 4 CR +2 V +2 12/11/25, 15:50

    thx. note i would have picked patch set 1 just as it was: this was a no-brainer. now i mixed 2 other topics: injecting the stateful UriBuilder, and changing label stuff.
  23. Christian Kuhn merged patch set 5 12/11/25, 15:50

  24. Benni Mack commented on patch set 5 12/11/25, 16:43

    Reply

    note 2: UriBuilder contains state, just like ConnectionPool, Router, TcaSchemaFactory. State that I consider "configuration".