Review 13.4 Merged

92117[BUGFIX] Avoid undefined array key access in DependencyOrderingService

Christian Kuhn CR +2 V +2 Normal +52 −32 updated 12/12/25, 13:32

Commit message

The `DependencyOrderingService` has been implement with must have
existing services in place for dependencies and is meanwhile also
used to support optional dependencies, for example to provide the
`optionalDependencies` in `SiteSets`.

This change guards array key accesses to support optional
dependencies while avoiding the php warning(s).

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn uploaded patch set 1 12/12/25, 13:22

  2. core-ci voted on patch set 1 V +1 12/12/25, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92145

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 12/12/25, 13:32

  4. Christian Kuhn merged patch set 2 12/12/25, 13:32