Review main Merged

92169[TASK] Clean up EditDocumentController

Benni Mack CR +2 V +2 Hard +317 −304 updated 12/19/25, 09:29

Commit message

This change cleans up some logic around persisting
records when editing in FormEngine.

It also inlines the methods init(), and preInit() and
main() into mainAction() so the flow of the execution
is more obvious, without obfuscated ResponseInterface
parts.

Superfluous protected properties have been removed.

This is a first step to split up processing
and rendering of records within FormEngine in the
future, and deal with real redirect() and forward()
logic, as well as clarifying the responsibilities.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1420

  1. Benni Mack uploaded patch set 1 12/18/25, 16:17

  2. Benni Mack marked it work in progress 12/18/25, 16:17

  3. core-ci voted on patch set 1 V -1 12/18/25, 16:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92432

  4. Benni Mack uploaded patch set 2 V -1 12/18/25, 16:43

  5. Benni Mack marked it ready for review 12/18/25, 16:43

  6. Benni Mack uploaded patch set 3 12/18/25, 16:50

  7. core-ci voted on patch set 2 V -1 12/18/25, 16:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92434

  8. core-ci voted on patch set 3 V -1 12/18/25, 17:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92435

  9. Benni Mack uploaded patch set 4 V -1 12/18/25, 19:58

  10. core-ci voted on patch set 4 V +1 12/18/25, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92441

  11. Benni Mack uploaded patch set 5 V +1 12/18/25, 20:30

  12. core-ci voted on patch set 5 V +1 12/18/25, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92445

  13. Christian Kuhn commented on patch set 5 12/18/25, 22:48

    FormAction.php:135

    nit: i like to have such factory methods directly below private __construct() since they are so directly bound to each other.
  14. Benni Mack commented on patch set 6 V +1 12/19/25, 07:43

    Published edit on patch set 5.
  15. Benni Mack commented on patch set 6 12/19/25, 07:43

    FormAction.php:135 Reply

    Done
  16. core-ci voted on patch set 6 V +1 12/19/25, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92462

  17. Garvin Hicking voted on patch set 6 CR +1 V +1 12/19/25, 09:29

  18. Georg Ringer voted on patch set 6 CR +1 V +1 12/19/25, 09:29

  19. Georg Ringer voted on patch set 6 CR +2 V +2 12/19/25, 09:29

  20. Georg Ringer merged patch set 7 12/19/25, 09:29