Review main Merged

92203[TASK] Update ISO Database

Anja Leichsenring CR +2 V +2 Expert +1261 −1162 updated 12/24/25, 10:15

Commit message

Used command(s):

  Build/Scripts/runTests.sh -s composer -- require \
    --dev 'sokil/php-isocodes-db-i18n':'^4.0.28' \
  && Build/Scripts/runTests.sh -s composer -- exec \
    Build/Scripts/updateIsoDatabase.php

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Josef Glatz +1
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Josef Glatz +1
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 58

Show 38 more files

Review log 1213

  1. Anja Leichsenring uploaded patch set 1 12/22/25, 06:33

  2. core-ci voted on patch set 1 V +1 12/22/25, 06:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92572

  3. Garvin Hicking commented on patch set 1 12/22/25, 07:02

    OfficialLanguages.php:187

    hm. Do we need a fallback? What happens to instances that used "bh"?!
  4. Anja Leichsenring commented on patch set 1 V -1 12/22/25, 09:51

    a fallback for the removed key is required.
  5. Josef Glatz commented on patch set 1 12/22/25, 11:42

    OfficialLanguages.php:187 Reply

    How does other systems handle such stuff? Is it the correct way to handle those within our codebase?
  6. Christian Kuhn commented on patch set 1 CR +1 V +1 12/23/25, 13:50

    OfficialLanguages.php:187 Reply

    i'd say bihari is not an official typo3 language and it is quite unlikely an instance will suffer from this. let's bring this in to make core green again, and only act further if this truly breaks projects in practice.
  7. Anja Leichsenring voted on patch set 1 V 0 12/23/25, 13:55

  8. Oliver Klee voted on patch set 1 CR +1 V +1 12/23/25, 14:46

  9. Josef Glatz voted on patch set 1 CR +1 V +1 12/23/25, 17:02

  10. Christian Kuhn commented on patch set 1 12/24/25, 09:58

    OfficialLanguages.php:187 Reply

    Done
  11. Stefan Bürk voted on patch set 1 CR +1 V +1 12/24/25, 10:14

  12. Anja Leichsenring voted on patch set 1 CR +2 V +2 12/24/25, 10:15

  13. Anja Leichsenring merged patch set 2 12/24/25, 10:15