Review 13.4 Merged

92277[BUGFIX] Add is_siteroot to select fields in record lists

Simon Praetorius CR +2 V +2 Easy +1 −0 updated 01/10/26, 18:30

Commit message

The column `is_siteroot` must be selected as well to be able to show the
proper icon in the recordlist for pages. Otherwise the IconFactory misses the information.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
  • Verified V +2 Done
    • Simon Praetorius +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Simon Praetorius commented on patch set 1 01/10/26, 18:18

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Controller/RecordListController.php
  2. Simon Praetorius uploaded patch set 2 01/10/26, 18:23

  3. Simon Praetorius commented on patch set 2 01/10/26, 18:24

    This change is ready for review.
    validated locally that in 13.4 only one change is necessary to cover both initial icon and icon after visibility change.
  4. core-ci voted on patch set 2 V +1 01/10/26, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93216

  5. core-ci voted on patch set 1 V -1 01/10/26, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93215

  6. Simon Praetorius voted on patch set 2 CR +2 V +2 01/10/26, 18:30

  7. Simon Praetorius merged patch set 3 01/10/26, 18:30