Review main Merged

92394[BUGFIX] Use correct tests for checking sorting

Georg Ringer CR +2 V +2 Easy +24 −2 updated 01/21/26, 11:50

Commit message

Using `assertEqualsCanonicalizing` is wrong as this ignores the order
which is what the test try to validate.

Change the assertion to really test it.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Georg Ringer uploaded patch set 1 01/19/26, 20:56

  2. Georg Ringer commented on patch set 1 01/19/26, 20:56

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 01/19/26, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93798

  4. Oliver Klee commented on patch set 1 01/20/26, 14:39

    FileListTest.php:52

    I find this unnecessarily complex to read. Instead, I'd like to propose using an array with literal strings for `$expected`.

    FileListTest.php:57

    Please let's harden the fn by adding a type and return type declaration.

    FileListTest.php:59

    This mixes the "execute" and the "verify" steps. I propose having the call separate, then a blank line, and then the stringification and the assert.

    FileListTest.php:60

    We need to use `assertSame` to also check the order of the elements.

    FileListTest.php:92

    Ditto everything. :-)
  5. Georg Ringer uploaded patch set 2 V +1 01/20/26, 20:05

  6. Georg Ringer commented on patch set 2 01/20/26, 20:05

    FileListTest.php:52 Reply

    would like to keep that to avoid the repeating complicated file names when it comes to special chars

    FileListTest.php:57 Reply

    Done

    FileListTest.php:59 Reply

    Done

    FileListTest.php:60 Reply

    Done

    FileListTest.php:92 Reply

    Done
  7. core-ci voted on patch set 2 V +1 01/20/26, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93888

  8. Oliver Klee uploaded patch set 3 V +1 01/21/26, 11:33

  9. Oliver Klee commented on patch set 2 01/21/26, 11:33

    FileListTest.php:52 Reply

    Acknowledged
  10. Oliver Klee voted on patch set 3 CR +1 V +1 01/21/26, 11:33

  11. core-ci voted on patch set 3 V +1 01/21/26, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93938

  12. Benni Mack voted on patch set 3 CR +2 V +2 01/21/26, 11:50

  13. Benni Mack merged patch set 4 01/21/26, 11:50