Review 13.4 Merged

92450[BUGFIX] Fix undefined array key warning in language menu processing

Georg Ringer CR +2 V +2 Easy +4 −0 updated 01/22/26, 06:55

Commit message

When processing language menu items with manually specified language IDs
that don't exist in the site configuration, the code attempted to access
`$languages[$sUid]` without checking if the key exists, causing a PHP
warning.

This fix adds an `isset()` check before accessing the language array to
gracefully skip invalid language IDs instead of throwing a warning.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Himanshu Nitsan +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Himanshu Nitsan +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Georg Ringer commented on patch set 1 01/22/26, 06:35

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/22/26, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94007

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 01/22/26, 06:41

  4. Himanshu Nitsan voted on patch set 1 CR +1 V +1 01/22/26, 06:52

  5. Georg Ringer voted on patch set 1 CR +2 V +2 01/22/26, 06:55

  6. Georg Ringer merged patch set 2 01/22/26, 06:55