Review main Merged

92542[BUGFIX] Respect language in CategoryBasedFileCollection

Benni Mack CR +2 V +2 Easy +26 −3 updated 09/02/26, 09:08

Commit message

CategoryBasedFileCollection now respects the current language context
when loading files. The query filters sys_file_metadata records by
sys_language_uid, including the current language, default language (0),
and "all languages" (-1).

Records are ordered by sys_language_uid DESC to ensure translated
metadata takes precedence over default language metadata, preventing
duplicate files in the collection.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Wouter Wolters +1
    • Sascha Nowak +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Sascha Nowak +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1319

  1. Benni Mack uploaded patch set 1 01/27/26, 20:57

  2. core-ci voted on patch set 1 V +1 01/27/26, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94449

  3. Benni Mack rebased onto patch set 2 V +1 04/21/26, 19:34

  4. core-ci voted on patch set 2 V -1 04/21/26, 19:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100666

  5. Benni Mack rebased onto patch set 3 V -1 04/22/26, 05:23

  6. core-ci voted on patch set 3 V +1 04/22/26, 05:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100683

  7. Benni Mack updated the commit message in patch set 4 V +1 04/22/26, 07:22

  8. Benni Mack rebased onto patch set 5 07/02/26, 09:40

  9. core-ci voted on patch set 5 V -1 07/02/26, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104223

  10. Benni Mack rebased onto patch set 6 V -1 07/03/26, 06:06

  11. core-ci voted on patch set 6 V +1 07/03/26, 06:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104261

  12. Benni Mack rebased onto patch set 7 V +1 09/02/26, 05:19

  13. core-ci voted on patch set 7 V +1 09/02/26, 05:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107558

  14. Simon Schaufelberger voted on patch set 7 CR +1 V +1 09/02/26, 06:10

  15. Sascha Nowak voted on patch set 7 CR +1 V +1 09/02/26, 06:38

  16. Wouter Wolters voted on patch set 7 CR +1 09/02/26, 06:45

  17. Garvin Hicking voted on patch set 7 CR +1 V +1 09/02/26, 09:07

  18. Benni Mack voted on patch set 7 CR +2 V +2 09/02/26, 09:08

  19. Benni Mack merged patch set 8 09/02/26, 09:08