Review main Merged

9264[FEATURE] Add hook to stdWrap_cacheStore

Fabrizio Branca CR +2 V +2 Easy +12 −0 updated 06/03/13, 20:49

Commit message

In issue #34299 caching for stdWrap was introduced.

With this patch I'd like to add a hook to the cacheStore method.
Using this patch cache handling can be refined. usecases are
- reuse provided tags for page tags
- memorize lifetimes so that the pages lifetime can be limited
to the shortest stdWrap lifetime

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Tolleiv Nietsch +1
    • Daniel Poetzinger +1
    • Simon Schaufelberger +1
  • Verified V +2
    • Steffen Ritter +2
    • Tolleiv Nietsch +1
    • Daniel Poetzinger +1

Issues 1

Files 1

Review log 12

  1. Daniel Poetzinger commented on patch set 2 03/13/12, 08:57

    Verified; Looks good to me, but someone else must approve
  2. Tolleiv Nietsch uploaded patch set 2 03/13/12, 08:57

  3. Tolleiv Nietsch commented on patch set 2 03/13/12, 08:57

    Verified; Looks good to me, but someone else must approve As discussed today - makes total sense this way :)
  4. Fabrizio Branca commented on patch set 2 03/13/12, 08:57

    That acutally depends what you aim to do in that hook. In my opionen the hook should be used to do some other tasks with the provided data and not to modify the data in that process. We could have the return value overwrite the content, but that would break everything if not used correctly. So I'd prefer to keep it as it is.
  5. Steffen Ritter commented on patch set 2 V 0 03/13/12, 08:57

    by team member; Looks good to me, approved
  6. Simon Schaufelberger commented on patch set 2 03/13/12, 08:57

    would be nice to have some use cases of course how to use the hook and what can be done with it.
  7. Simon Schaufelberger commented on patch set 2 03/13/12, 08:57

    i mean code snippets ;)
  8. Simon Schaufelberger commented on patch set 2 03/13/12, 08:57

    should the userfunction not return something?
  9. Simon Schaufelberger commented on patch set 2 03/13/12, 08:57

    Looks good to me, but someone else must approve
  10. Mr. Jenkins commented on patch set 1 03/13/12, 08:57

  11. Mr. Jenkins commented on patch set 2 03/13/12, 08:57

  12. Steffen Ritter merged patch set 2 03/13/12, 08:57