Review main Merged

92836[BUGFIX] Use correct node property for linkable check in page browser

Benni Mack CR +2 V +2 Easy +2 −2 updated 04/21/26, 15:04

Commit message

The isLinkable() method in PageBrowserTree incorrectly used
node.recordType (which is always the string "pages") instead of
node.doktype to determine whether a page type is linkable.
Number("pages") evaluates to NaN, causing every page to be
considered linkable, including Spacer and SysFolder.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Benni Mack uploaded patch set 1 02/13/26, 13:15

  2. core-ci voted on patch set 1 V +1 02/13/26, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95830

  3. Sascha Egerer commented on patch set 1 02/13/26, 14:51

    This should also be backported to v13
  4. Benni Mack commented on patch set 1 02/13/26, 15:04

    Reply

    ah, no, sorry I just introduced this in #97898 in 14.0 - https://review.typo3.org/c/Packages/TYPO3.CMS/+/92485
  5. Georg Ringer voted on patch set 1 CR +1 V +1 02/13/26, 20:45

  6. Josua Vogel voted on patch set 1 CR +1 V +1 02/13/26, 20:55

  7. Georg Ringer voted on patch set 1 CR +2 V +2 02/13/26, 21:01

  8. Georg Ringer merged patch set 2 02/13/26, 21:01

  9. Sascha Egerer commented on patch set 2 02/13/26, 21:24

    Reply Unresolved

    But the bug itself does also exist in v13. That's what i meant. Even if I dont understand why, because the doktype of sysfolder is in the static list (254), but it is still "linkable" from the page tree and not in the "content part" of the link popup. I hope you understand what i'm talking about. If not i can also create a dedicated ticket for v13.