9294[FEATURE] Add stdWrap feature: addPageCacheTags
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Steffen Ritter +1
-
Verified V +2
- Christian Kuhn +2
- Steffen Ritter +1
Issues 1
Files 2
Review log 28
Show 3 earlier messages
-
Stefan Neufeind commented on patch set 1 03/30/13, 11:28
No score I like the idea. But thinking further about it I wonder if: * we should maybe had optional stdWrap for this setting as well - which would allow things like insertData to work oder fetching tags from a cObject (created using a COA, ...) * we should maybe have a clean "list" instead of a comma-separated list, which would allow to flexibly set/unset things, ... Imho both :-) But I like the general idea though.6.0 nowclass.tslib_content.php:58since you added this array here as well, do you plan to use that for another stdWrap on the addPageCacheTags-value to be assigned? Might be a nice addition. So then you could use things like wrap, fetching fields from somewhere or the like on this value as well. This would then however require another call in your new function like it is already done for example on the first line of stdWrap_hash(). -
Stefan Neufeind commented on patch set 1 2 comments 03/30/13, 11:28
Looks good to me, but someone else must approve Makes sense by reading and sounds like a nice addition. Fine by reading imho. Consider to maybe add another stdWrap into it (see inline). -
Philipp Gampe uploaded patch set 2 03/30/13, 11:28
-
Philipp Gampe uploaded patch set 3 03/30/13, 11:28
-
Philipp Gampe uploaded patch set 4 03/30/13, 11:28
-
Philipp Gampe uploaded patch set 5 03/30/13, 11:28
-
Stefan Neufeind commented on patch set 7 03/30/13, 11:28
Looks good to me, but someone else must approve -
Benni Mack uploaded patch set 7 03/30/13, 11:28
-
Christian Kuhn commented on patch set 7 03/30/13, 11:28
(1 inline comment)ContentObjectRendererTest.php:54false as last param is probably there to not raise a warning somewhere. -
Christian Kuhn commented on patch set 7 03/30/13, 11:28
Fails 285 (!) failing tests. -
Christian Kuhn uploaded patch set 8 03/30/13, 11:28
-
Christian Kuhn commented on patch set 8 03/30/13, 11:28
Verified; Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 8 V 0 03/30/13, 11:28
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 9 03/30/13, 11:28
-
Steffen Ritter commented on patch set 7 03/30/13, 11:28
Verified; Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 8 03/30/13, 11:28
Verified; Looks good to me, but someone else must approve -
Philipp Gampe uploaded patch set 6 03/30/13, 11:28
-
Philipp Gampe commented on patch set 6 03/30/13, 11:28
Verified; Looks good to me, but someone else must approve Rebased and with unit test, I also added stdWrap to the new tag. -
Philipp Gampe commented on patch set 7 03/30/13, 11:28
Verified; Looks good to me, but someone else must approve -
Felix Kopp commented on patch set 1 03/30/13, 11:28
Should this feature be included? -
Mr. Jenkins commented on patch set 1 03/30/13, 11:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3476/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/30/13, 11:28
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7923/ : FAILURE -
Mr. Jenkins commented on patch set 3 03/30/13, 11:28
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7924/ : FAILURE -
Mr. Jenkins commented on patch set 4 03/30/13, 11:28
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7925/ : FAILURE -
Mr. Jenkins commented on patch set 6 03/30/13, 11:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7927/ : SUCCESS -
Mr. Jenkins commented on patch set 7 03/30/13, 11:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7930/ : SUCCESS -
Mr. Jenkins commented on patch set 8 03/30/13, 11:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8000/ : SUCCESS -
Christian Kuhn commented on patch set 9 03/30/13, 11:28
Documentation issue: http://forge.typo3.org/issues/46800