Review main Merged

9294[FEATURE] Add stdWrap feature: addPageCacheTags

Fabrizio Branca CR +2 V +2 Normal +57 −3 updated 06/03/13, 20:49

Commit message

This feature comes after feature freeze for 4.7 but accidently it was
already mentioned in the release notes while not being implemented yet.

Release notes mention that the new stdWrap.cache feature (#34299)
stores cache tags that can be flushed by tag from TCEmain.clearCacheCmd
with feature #34352.

As stdWrap.cache stores tags into cache_hash and not into cache_pages
the feature mentioned in the release notes does not work that way.

But nevertheless that would be a handy feature and so I suggest to
add stdWrap.addPageCacheTags = pagetag1,pagetag2,pagetag3

To distinguish these tags being written to cache_pages instead of
cache_hash I'd suggest to not have this feature inside "cache." but
as a separate configuration option "addPageCacheTags".

See http://forge.typo3.org/issues/34403 for some more details.

Including the other cache (tag) related features this completes a set
of handy tools to handly cache tags in a very flexible way.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Steffen Ritter +1
  • Verified V +2
    • Christian Kuhn +2
    • Steffen Ritter +1

Issues 1

Files 2

Review log 28

Show 3 earlier messages
  1. Stefan Neufeind commented on patch set 1 03/30/13, 11:28

    No score I like the idea. But thinking further about it I wonder if: * we should maybe had optional stdWrap for this setting as well - which would allow things like insertData to work oder fetching tags from a cObject (created using a COA, ...) * we should maybe have a clean "list" instead of a comma-separated list, which would allow to flexibly set/unset things, ... Imho both :-) But I like the general idea though.
    6.0 now

    class.tslib_content.php:58

    since you added this array here as well, do you plan to use that for another stdWrap on the addPageCacheTags-value to be assigned? Might be a nice addition. So then you could use things like wrap, fetching fields from somewhere or the like on this value as well. This would then however require another call in your new function like it is already done for example on the first line of stdWrap_hash().
  2. Stefan Neufeind commented on patch set 1 2 comments 03/30/13, 11:28

    Looks good to me, but someone else must approve Makes sense by reading and sounds like a nice addition. Fine by reading imho. Consider to maybe add another stdWrap into it (see inline).
  3. Philipp Gampe uploaded patch set 2 03/30/13, 11:28

  1. Philipp Gampe uploaded patch set 3 03/30/13, 11:28

  2. Philipp Gampe uploaded patch set 4 03/30/13, 11:28

  3. Philipp Gampe uploaded patch set 5 03/30/13, 11:28

  4. Stefan Neufeind commented on patch set 7 03/30/13, 11:28

    Looks good to me, but someone else must approve
  5. Benni Mack uploaded patch set 7 03/30/13, 11:28

  6. Christian Kuhn commented on patch set 7 03/30/13, 11:28

    (1 inline comment)

    ContentObjectRendererTest.php:54

    false as last param is probably there to not raise a warning somewhere.
  7. Christian Kuhn commented on patch set 7 03/30/13, 11:28

    Fails 285 (!) failing tests.
  8. Christian Kuhn uploaded patch set 8 03/30/13, 11:28

  9. Christian Kuhn commented on patch set 8 03/30/13, 11:28

    Verified; Looks good to me, but someone else must approve
  10. Christian Kuhn commented on patch set 8 V 0 03/30/13, 11:28

    by team member; Looks good to me, approved
  11. Christian Kuhn merged patch set 9 03/30/13, 11:28

  12. Steffen Ritter commented on patch set 7 03/30/13, 11:28

    Verified; Looks good to me, but someone else must approve
  13. Steffen Ritter commented on patch set 8 03/30/13, 11:28

    Verified; Looks good to me, but someone else must approve
  14. Philipp Gampe uploaded patch set 6 03/30/13, 11:28

  15. Philipp Gampe commented on patch set 6 03/30/13, 11:28

    Verified; Looks good to me, but someone else must approve Rebased and with unit test, I also added stdWrap to the new tag.
  16. Philipp Gampe commented on patch set 7 03/30/13, 11:28

    Verified; Looks good to me, but someone else must approve
  17. Felix Kopp commented on patch set 1 03/30/13, 11:28

    Should this feature be included?
  18. Mr. Jenkins commented on patch set 1 03/30/13, 11:28

  19. Mr. Jenkins commented on patch set 2 03/30/13, 11:28

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7923/ : FAILURE
  20. Mr. Jenkins commented on patch set 3 03/30/13, 11:28

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7924/ : FAILURE
  21. Mr. Jenkins commented on patch set 4 03/30/13, 11:28

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7925/ : FAILURE
  22. Mr. Jenkins commented on patch set 6 03/30/13, 11:28

  23. Mr. Jenkins commented on patch set 7 03/30/13, 11:28

  24. Mr. Jenkins commented on patch set 8 03/30/13, 11:28

  25. Christian Kuhn commented on patch set 9 03/30/13, 11:28