Review 13.4 Merged

93018[BUGFIX] Use correct node property for linkable check in page browser

Georg Ringer CR +2 V +2 Easy +2 −2 updated 02/26/26, 21:12

Commit message

The isLinkable() method in PageBrowserTree incorrectly used
node.recordType (which is always the string "pages") instead of
node.doktype to determine whether a page type is linkable.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 67

  1. Georg Ringer uploaded patch set 1 02/26/26, 19:48

  2. Georg Ringer commented on patch set 1 02/26/26, 19:48

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 02/26/26, 19:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96937

  4. Benni Mack commented on patch set 1 CR +1 V +1 02/26/26, 20:09

    thank you
  5. Garvin Hicking voted on patch set 1 CR +1 V +1 02/26/26, 21:05

  6. Georg Ringer voted on patch set 1 CR +2 V +2 02/26/26, 21:12

  7. Georg Ringer merged patch set 2 02/26/26, 21:12