93038[TASK] Resolve simple issues of phpstan
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Garvin Hicking +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Garvin Hicking +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 9
- Build/phpstan/phpstan-baseline.neon+0 −66
- typo3/sysext/core/Classes/Cache/CacheManager.php+1 −3
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+3 −3
- typo3/sysext/core/Classes/Log/LogDataTrait.php+1 −2
- typo3/sysext/core/Classes/Service/MarkerBasedTemplateService.php+6 −8
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/DatabaseUpdatedPrerequisite.php+1 −1
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/ReferenceIndexUpdatedPrerequisite.php+1 −1
- typo3/sysext/lowlevel/Classes/Command/DeletedRecordsCommand.php+2 −2
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php6+10 −14
Review log 1621
-
Georg Ringer uploaded patch set 1 03/02/26, 19:12
-
Georg Ringer commented on patch set 1 03/02/26, 19:13
This change is ready for review. -
Garvin Hicking commented on patch set 1 03/02/26, 19:34
ConfigurationStatus.php:149```suggestion if (function_exists('memcache_connect') && $memcachedServers !== []) { ``` -
core-ci voted on patch set 1 V -1 03/02/26, 19:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97131
-
Georg Ringer uploaded patch set 2
V -103/02/26, 20:00 -
core-ci voted on patch set 2 V +1 03/02/26, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97136
-
Garvin Hicking commented on patch set 2 CR -1 03/02/26, 20:21
ConfigurationStatus.php:149ReplyActually. This is only php-doc. The array is not enforced. We cannot do it like this. -
Garvin Hicking commented on patch set 2 03/02/26, 20:43
ConfigurationStatus.php:149ReplyHow about changing that inside the method: ``` $memcachedServers = $configurations[$table]['options']['servers']; ``` to perform an "is_array" check for that array result: ``` if (is_array($configurations[$table]['options']['servers'])) { $memcachedServers = $configurations[$table]['options']['servers']; } ``` -
Benni Mack uploaded patch set 3
CR -1V +103/04/26, 16:14 -
core-ci voted on patch set 3 V +1 03/04/26, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97343
-
Oliver Klee commented on patch set 3 03/04/26, 17:42
ConfigurationStatus.php:149Can we avoid the `empty` here and instead use `is_array`? -
Garvin Hicking uploaded patch set 4
V +103/05/26, 08:39 -
Garvin Hicking uploaded patch set 5 03/05/26, 08:40
-
core-ci voted on patch set 5 V +1 03/05/26, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97392
-
core-ci voted on patch set 4 V -1 03/05/26, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97391
-
Garvin Hicking commented on patch set 5 CR +1 V +1 03/05/26, 09:33
ConfigurationStatus.php:149ReplyDone -
Garvin Hicking commented on patch set 5 03/05/26, 09:33
ConfigurationStatus.php:149ReplyDone -
Oliver Klee voted on patch set 5 CR +1 V +1 03/05/26, 10:39
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 03/05/26, 12:29
-
Georg Ringer voted on patch set 5 CR +2 V +2 03/05/26, 13:10
-
Georg Ringer merged patch set 6 03/05/26, 13:10