Review main Merged

93038[TASK] Resolve simple issues of phpstan

Georg Ringer CR +2 V +2 Normal +25 −100 updated 03/05/26, 13:10

Commit message

Slim down the baseline little by little, add type declarations
to protected methods in ConfigurationStatus.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1621

  1. Georg Ringer uploaded patch set 1 03/02/26, 19:12

  2. Georg Ringer commented on patch set 1 03/02/26, 19:13

    This change is ready for review.
  3. Garvin Hicking commented on patch set 1 03/02/26, 19:34

    ConfigurationStatus.php:149

    ```suggestion if (function_exists('memcache_connect') && $memcachedServers !== []) { ```
  4. core-ci voted on patch set 1 V -1 03/02/26, 19:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97131

  5. Georg Ringer uploaded patch set 2 V -1 03/02/26, 20:00

  6. core-ci voted on patch set 2 V +1 03/02/26, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97136

  7. Garvin Hicking commented on patch set 2 CR -1 03/02/26, 20:21

    ConfigurationStatus.php:149 Reply

    Actually. This is only php-doc. The array is not enforced. We cannot do it like this.
  8. Garvin Hicking commented on patch set 2 03/02/26, 20:43

    ConfigurationStatus.php:149 Reply

    How about changing that inside the method: ``` $memcachedServers = $configurations[$table]['options']['servers']; ``` to perform an "is_array" check for that array result: ``` if (is_array($configurations[$table]['options']['servers'])) { $memcachedServers = $configurations[$table]['options']['servers']; } ```
  9. Benni Mack uploaded patch set 3 CR -1 V +1 03/04/26, 16:14

  10. core-ci voted on patch set 3 V +1 03/04/26, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97343

  11. Oliver Klee commented on patch set 3 03/04/26, 17:42

    ConfigurationStatus.php:149

    Can we avoid the `empty` here and instead use `is_array`?
  12. Garvin Hicking uploaded patch set 4 V +1 03/05/26, 08:39

  13. Garvin Hicking uploaded patch set 5 03/05/26, 08:40

  14. core-ci voted on patch set 5 V +1 03/05/26, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97392

  15. core-ci voted on patch set 4 V -1 03/05/26, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97391

  16. Garvin Hicking commented on patch set 5 CR +1 V +1 03/05/26, 09:33

    ConfigurationStatus.php:149 Reply

    Done
  17. Garvin Hicking commented on patch set 5 03/05/26, 09:33

    ConfigurationStatus.php:149 Reply

    Done
  18. Oliver Klee voted on patch set 5 CR +1 V +1 03/05/26, 10:39

  19. Simon Schaufelberger voted on patch set 5 CR +1 V +1 03/05/26, 12:29

  20. Georg Ringer voted on patch set 5 CR +2 V +2 03/05/26, 13:10

  21. Georg Ringer merged patch set 6 03/05/26, 13:10