Review main Abandoned

93043[TASK] Speed up site settings editing: Skip processing of empty tree settings

internetgalerie internetgalerie CR -1 V 0 Easy +21 −19 updated 03/13/26, 12:27

Commit message

Review

  • Code review CR -1
    • Garvin Hicking -1
  • Verified V 0
    • core-ci +1 CI

Files 1

Review log 34

  1. internetgalerie internetgalerie uploaded patch set 1 03/03/26, 15:43

  2. core-ci voted on patch set 1 V +1 03/03/26, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97199

  3. Garvin Hicking commented on patch set 1 CR -1 03/03/26, 22:12

    Thanks for contributing! According to our contribution guidelines: https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/BugfixingAZ/Index.html#create-a-patch We need: - an issue number, in "Resolves:" last header line. Please see other patches, and create an issue in forge.typo3.org - A commit body describing what this does, see guideline for example commit bodies. You can use (parts) of what you wrote in the issue - your commit subject must not be longer than 72 characters (currently 78) Code-wise, it would be better to not use "empty()" but an "$treesettings !== []" comparison, as empty() performs too many checks that are not type-ensuring. Maybe you also want to check out https://review.typo3.org/c/Packages/TYPO3.CMS/+/90283 as that contains a bit similar optimization?
  4. Garvin Hicking abandoned the change 03/13/26, 12:27

    abandoning with lack of feedback; feel free to reopen when comments are addressed