Review main Merged

9310[TASK] Remove typo3/logomenu.php

Christian Kuhn CR +2 V +2 Normal +0 −181 updated 06/03/13, 20:49

Commit message

typo3/logomenu.php contains class SC_logomenu that extends t3lib_topmenubase.
But t3lib_topmenubase does not exist anymore since TYPO3 4.2, so SC_logomenu
is broken.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 11

  1. Xavier Perseguers commented on patch set 1 02/29/12, 22:52

    Verified; Looks good to me, but someone else must approve
  2. Christian Kuhn commented on patch set 1 V 0 02/29/12, 22:52

    by team member; Looks good to me, approved
  3. Markus Klein commented on patch set 2 02/29/12, 22:52

    No, not unkown. Lines are too long (74 chars)
  4. Christian Kuhn uploaded patch set 2 02/29/12, 22:52

  5. Christian Kuhn commented on patch set 2 V 0 02/29/12, 22:52

    by team member; Looks good to me, approved
  6. Christian Kuhn commented on patch set 2 02/29/12, 22:52

    jenkins sucks here for unknown reasons: This was the reason for patch set 2, i was unable to merge otherwise, and just merged before the jenkins run was complete ^^
  7. Christian Kuhn merged patch set 2 02/29/12, 22:52

  8. Sebastian Fischer commented on patch set 1 02/29/12, 22:52

    Verified; Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 1 02/29/12, 22:52

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3479/ : FAILURE
  10. Mr. Jenkins commented on patch set 2 02/29/12, 22:52

  11. Markus Klein commented on patch set 2 02/29/12, 22:52