Review main Merged

93116[DOCS] Clarify the correct migration of TSFE->config['config']

Simon Schaufelberger CR +2 V +2 Easy +3 −3 updated 03/09/26, 12:22

Commit message

The documentation stated that TypoScriptFrontendController->config must
be migrated but only with the subarray key 'config' as other keys like
'rootline' have a different migration path.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1214

  1. Simon Schaufelberger uploaded patch set 1 03/07/26, 21:40

  2. core-ci voted on patch set 1 V +1 03/07/26, 21:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97551

  3. Garvin Hicking commented on patch set 1 03/08/26, 08:58

    Breaking-102621-MostTSFEMembersMarkedInternalOrRead-only.rst:18

    Please don't remove this. (Applies to all the changes here.)
  4. Simon Schaufelberger commented on patch set 1 03/08/26, 09:59

    Breaking-102621-MostTSFEMembersMarkedInternalOrRead-only.rst:18 Reply

    When using backticks, the Text is rendered as code. When it has the php Tag, it will render a stupid modal window which is very annoying and in this case, it's not even real php code but only a class name which is actually just a string.
  5. Simon Schaufelberger commented on patch set 1 03/08/26, 10:01

    Breaking-102621-MostTSFEMembersMarkedInternalOrRead-only.rst:18 Reply

    Lina is also not a big fan of the overuse of this Tag when you ask her.
  6. Garvin Hicking commented on patch set 1 CR -1 03/08/26, 10:31

    Breaking-102621-MostTSFEMembersMarkedInternalOrRead-only.rst:18 Reply

    I think it's an important semantic. We should provide that. Then we can always replace a "stupid modal". We know nothing about a snippet if these semantics are missing.
  7. Simon Schaufelberger uploaded patch set 2 CR -1 V +1 03/08/26, 19:20

  8. Simon Schaufelberger commented on patch set 2 03/08/26, 19:21

    Breaking-102621-MostTSFEMembersMarkedInternalOrRead-only.rst:18 Reply

    I would really appreciate any documentation where the correct usage of the tags are written down.
  9. core-ci voted on patch set 2 V +1 03/08/26, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97573

  10. Garvin Hicking commented on patch set 2 03/08/26, 19:39

    Breaking-102621-MostTSFEMembersMarkedInternalOrRead-only.rst:18 Reply

    Thanks. I'll try to find time to search for it, but I think our "how to document" guide has all language semantic annotations somewhere. (As for this patch I'd have to check the config['config'] use so I can't vote for it atm, but if anyone knows for sure please vote)
  11. Christian Kuhn voted on patch set 2 CR +1 V +1 03/09/26, 11:52

  12. Josua Vogel voted on patch set 2 CR +1 V +1 03/09/26, 11:57

  13. Garvin Hicking voted on patch set 2 CR +2 V +2 03/09/26, 12:22

  14. Garvin Hicking merged patch set 3 03/09/26, 12:22