Review main Merged

9327[FEATURE] Adding hook in flushByTag

Fabrizio Branca CR +2 V +2 Easy +7 −0 updated 06/03/13, 20:49

Commit message

Cache tags could be reused for nc_staticfile cache or even for tagging
varnish cache content. When it is flushed using the caching framework
there should be a hook in place that allows to also purge other
external caches.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Tolleiv Nietsch +1
  • Verified V +2
    • Steffen Ritter +2
    • Tolleiv Nietsch +1

Issues 1

Files 1

Review log 11

  1. Philipp Gampe commented on patch set 1 03/13/12, 08:54

    (1 inline comment)
    We already branched, thus this needs to be 4.7, 4.8
  2. Philipp Gampe uploaded patch set 2 03/13/12, 08:54

  3. Philipp Gampe commented on patch set 2 03/13/12, 08:54

    Looks good to me, but someone else must approve I just changed the commit message.
  4. Tolleiv Nietsch commented on patch set 3 03/13/12, 08:54

    Verified; Looks good to me, but someone else must approve
  5. Steffen Ritter commented on patch set 3 V 0 03/13/12, 08:54

    by team member; Looks good to me, approved
  6. Philipp Gampe uploaded patch set 3 03/13/12, 08:54

  7. Philipp Gampe commented on patch set 3 03/13/12, 08:54

    Of course feature freeze is in effect, thus only 4.8
  8. Mr. Jenkins commented on patch set 1 03/13/12, 08:54

  9. Mr. Jenkins commented on patch set 2 03/13/12, 08:54

  10. Mr. Jenkins commented on patch set 3 03/13/12, 08:54

  11. Steffen Ritter merged patch set 3 03/13/12, 08:54