Review main Merged

93361[BUGFIX] Remove title attribute from thumbnail elements

Christian Jung CR +2 V +2 Easy +0 −1 updated 05/02/26, 16:56

Commit message

In the TYPO3 backend the “Media” module, thumbnails are currently
announced by screen readers.

While they are marked up as decorative with empty alt attribute
values, the title attribute serves as the last fallback value in
accessible name resolution and exposes them to assistive technologies.

The title attribute value is redundant as it duplicates the visible
file name.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Christian Rath-Ulrich +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Christian Rath-Ulrich +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1621

  1. Christian Jung uploaded patch set 1 03/26/26, 08:11

  2. core-ci voted on patch set 1 V +1 03/26/26, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98755

  3. Simon Schaufelberger commented on patch set 1 03/26/26, 09:11

    Please read the commit message rules from TYPO3 and follow them
  4. Jennifer Geiß voted on patch set 1 V +1 03/26/26, 09:45

  5. Simon Schaufelberger commented on patch set 1 03/26/26, 12:25

    Reply

    You can find them here: https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html#commitmessage I suggest: Remove title attribute from thumbnail elements
    Add "the" File List module
  6. Chris Müller updated the commit message in patch set 2 V +1 03/26/26, 15:39

  7. Chris Müller updated the commit message in patch set 3 03/26/26, 15:40

  8. Chris Müller commented on patch set 3 03/26/26, 15:40

    Reply

    Done
  9. core-ci voted on patch set 2 V +1 03/26/26, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98799

  10. core-ci voted on patch set 3 V -1 03/26/26, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98800

  11. Simon Schaufelberger commented on patch set 3 03/26/26, 16:07

    Reply

    Done
  12. core-ci voted on patch set 3 V +1 03/26/26, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98800

  13. Georg Ringer voted on patch set 3 CR +1 V +1 04/17/26, 18:59

  14. Oliver Klee voted on patch set 3 CR +1 04/17/26, 20:46

  15. Benni Mack updated the commit message in patch set 4 CR +1 V +1 04/22/26, 07:16

  16. core-ci voted on patch set 4 V +1 04/22/26, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100856

  17. Oliver Klee voted on patch set 4 CR +1 04/22/26, 11:53

  18. Christian Rath-Ulrich voted on patch set 4 CR +1 V +1 04/27/26, 07:56

  19. Jörg Bösche voted on patch set 4 CR +1 04/28/26, 06:40

  20. Christian Kuhn voted on patch set 4 CR +2 V +2 05/02/26, 16:02

  21. Christian Kuhn merged patch set 5 05/02/26, 16:56