93409[TASK] Clarify usage recommendation for `GeneralUtility::makeInstance`
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- Oliver Klee +1
- Torben Hansen +1
-
Verified V +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- Oliver Klee +1
- Torben Hansen +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1315
-
Elias Häußler uploaded patch set 1 03/27/26, 17:15
-
core-ci voted on patch set 1 V +1 03/27/26, 17:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98905
-
Nikita Hovratov voted on patch set 1 CR +1 V +1 03/27/26, 17:28
-
Torben Hansen voted on patch set 1 CR +1 V +1 03/27/26, 17:29
-
Garvin Hicking voted on patch set 1 CR +1 V +1 03/27/26, 17:51
-
Garvin Hicking commented on patch set 1 03/27/26, 17:51
I think we should even backport this to v13. -
Elias Häußler rebased onto patch set 2
CR +1V +103/28/26, 10:47 -
Elias Häußler commented on patch set 2 03/28/26, 10:47
Reply
Makes sense, thanks for the suggestion. Please vote again 😊 -
Elias Häußler commented on patch set 2 03/28/26, 10:47
Reply
Done -
Georg Ringer voted on patch set 2 CR +1 V +1 03/28/26, 10:53
-
core-ci voted on patch set 2 V +1 03/28/26, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98945
-
Torben Hansen voted on patch set 2 CR +1 V +1 03/28/26, 10:57
-
Oliver Klee voted on patch set 2 CR +1 V +1 03/28/26, 11:39
-
Garvin Hicking voted on patch set 2 CR +2 V +2 03/28/26, 12:22
-
Garvin Hicking merged patch set 3 03/28/26, 12:23