Review main Ready for review Orphaned

93506[TASK] Restore logging on failed login attempts

Mathias Brodala CR 0 V 0 Easy +2 −2 updated 04/22/26, 11:34

Commit message

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/06/93506/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/06/93506/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 1

Issues 3

Files 1

Review log 1013

  1. Mathias Brodala uploaded patch set 1 04/01/26, 08:44

  2. core-ci voted on patch set 1 V -1 04/01/26, 08:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99370

  3. core-ci voted on patch set 1 V +1 04/01/26, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99370

  4. Oliver Klee voted on patch set 1 CR +1 04/01/26, 10:58

  5. Georg Ringer voted on patch set 1 CR +1 V +1 04/10/26, 08:31

  6. Josef Glatz voted on patch set 1 CR +1 V +1 04/10/26, 16:36

  7. Stefan Bürk commented on patch set 1 CR -1 04/11/26, 17:49

    Sorry, but I insist on an approval from the security team on this. I guess it should be okay, but we avoid the potential of the dark side. @oliver.hader@typo3.org @ben@bnf.dev
  8. Oliver Hader commented on patch set 1 04/17/26, 20:28

    Reply

    In case it can be ensure that no sensitive data is logged (back then it e.g. was session id and password), then it’s totally fine to use a different log level. Back then with the fix for TYPO3-CORE-SA-2019-010, the whole submitted log-data was logged per default: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60703
  9. Oliver Hader commented on patch set 1 04/17/26, 20:30

    Reply Unresolved

  10. Torben Hansen commented on patch set 1 CR -1 04/18/26, 07:57

    AbstractUserAuthentication.php:607

    Extensions providing a custom authentication service, which are either responsible for the subtypes `processLoginDataBE` or `processLoginDataFE` can extend the `$loginData` array with new fields, that might contain sensitive data. Those possible new fields are not handled by `removeSensitiveLoginDataForLoggingInfo`. Therefore, this should stay loglevel debug here.

    AbstractUserAuthentication.php:611 Unresolved

    This one is ok to change, since only user id and username is logged, when the login for a valid user was not successful.
  11. Mathias Brodala commented on patch set 1 04/18/26, 08:25

    AbstractUserAuthentication.php:607 Reply Unresolved

    OK, I'll add a separate warning log with only the essential data which cannot be changed by extensions. This would still cover the mentioned usecase to have a trace of failed login attempts before rate limit exhaustion.
  12. Benni Mack updated the commit message in patch set 2 CR +1 V +1 04/22/26, 06:47

  13. core-ci voted on patch set 2 V +1 04/22/26, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100797