Review main Merged

93625[TASK] Clean up DataMapProcessor and helpers

Christian Kuhn CR +2 V +2 Hard +234 −385 updated 04/12/26, 16:54

Commit message

`DataMapProcessor` in `DataHandling\Localization` analyzes
and modifies the datamap before `DataHandler` processes it,
synchronizing field values across language variants
and IRRE child records. Its logic is complex and it is
embedded in a nested `DataHandler` call chain.

The patch aims to simplify details for now: Various methods
don't manipulate properties directly anymore, but get state
hand over and return it manipulated. The class receives a
better comment to clarify the main logic. The two dependent
helper classes `State` and `DataMapItem` receive minor cleanups
along the way and are declared `@internal`, which they have
always have been in practice anyway. Work on these will
continue with further patches to improve their data object
characteristics.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1118

  1. Christian Kuhn uploaded patch set 1 04/11/26, 11:37

  2. core-ci voted on patch set 1 V -1 04/11/26, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99964

  3. Christian Kuhn uploaded patch set 2 V -1 04/11/26, 12:54

  4. core-ci voted on patch set 2 V -1 04/11/26, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99968

  5. Christian Kuhn uploaded patch set 3 V -1 04/12/26, 11:11

  6. core-ci voted on patch set 3 V +1 04/12/26, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100016

  7. Christian Kuhn uploaded patch set 4 V +1 04/12/26, 11:57

  8. core-ci voted on patch set 4 V +1 04/12/26, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100018

  9. Christian Kuhn uploaded patch set 5 V +1 04/12/26, 13:45

  10. core-ci voted on patch set 5 V +1 04/12/26, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100019

  11. Christian Kuhn updated the commit message in patch set 6 V +1 04/12/26, 13:57

  12. Oliver Klee updated the commit message in patch set 7 04/12/26, 14:05

  13. core-ci voted on patch set 6 V +1 04/12/26, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100020

  14. core-ci voted on patch set 7 V +1 04/12/26, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100021

  15. Anja Leichsenring voted on patch set 7 CR +1 V +1 04/12/26, 16:06

  16. Stefan Bürk voted on patch set 7 CR +1 V +1 04/12/26, 16:09

  17. Christian Kuhn voted on patch set 7 CR +2 V +2 04/12/26, 16:54

  18. Christian Kuhn merged patch set 8 04/12/26, 16:54