Review 13.4 Merged

93682[BUGFIX] Streamline returnUrl handling in PageLayoutController

Oliver Hader CR +2 V +2 Easy +1 −1 updated 04/17/26, 12:55

Commit message

A flaw with returnUrl in the PageLayoutController has been reported
to us by Hamed Kohi (0xHamy). However, potential security implications
are mitigated by Content-Security-Policy headers already.
That's why this flaw is addressed in public.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Oliver Hader uploaded patch set 1 04/15/26, 15:40

  2. core-ci voted on patch set 1 V +1 04/15/26, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100264

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 04/16/26, 07:20

    Thanks. I just all the 211 occurences of 'returnUrl' (and also `->returnUrl`) to ensure we also encode this in more v14 touched places (mostly EXT:form). Seems they're all good and use this sanitize call, or only access manually created routes, or use the URI from `$request->getAttribute('normalizedParams')->getRequestUri()`.
  4. Oliver Hader voted on patch set 1 CR +2 V +2 04/17/26, 12:55

  5. Oliver Hader merged patch set 2 04/17/26, 12:55