Review main Merged

93708[DOCS] Review changelogs for v14.3

Sarah McCarthy CR +2 V +2 Normal +123 −124 updated 04/20/26, 05:13

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Chris Müller +1
    • Georg Ringer +1
    • Ines Willenbrock +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Chris Müller +1
    • Georg Ringer +1
    • Ines Willenbrock +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1417

  1. Sarah McCarthy uploaded patch set 1 04/17/26, 08:48

  2. core-ci voted on patch set 1 V +1 04/17/26, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100372

  3. Chris Müller commented on patch set 1 CR -1 04/17/26, 17:40

    on it
  4. Chris Müller uploaded patch set 2 CR -1 V +1 04/17/26, 17:56

  5. Chris Müller voted on patch set 2 CR +1 V +1 04/17/26, 17:56

  6. core-ci voted on patch set 2 V +1 04/17/26, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100407

  7. Georg Ringer voted on patch set 2 CR +1 V +1 04/17/26, 18:16

  8. Ines Willenbrock commented on patch set 2 04/17/26, 19:00

    Deprecation-109523-GeneralUtilityIsOnCurrentHostWithoutRequest.rst:16

    Perhaps use "as the second argument" here

    Deprecation-109523-GeneralUtilityIsOnCurrentHostWithoutRequest.rst:40

    Same as above: perhaps use "as the second argument"

    Deprecation-109544-GeneralUtilitySanitizeLocalUrlWithoutRequest.rst:15

    perhaps use "as the second argument" here

    Deprecation-109544-GeneralUtilitySanitizeLocalUrlWithoutRequest.rst:34

    perhaps use "as the second argument" here

    Deprecation-109548-GeneralUtilityLocationHeaderUrlWithoutRequest.rst:15

    perhaps use "as the second argument" here

    Deprecation-109548-GeneralUtilityLocationHeaderUrlWithoutRequest.rst:34

    perhaps use "as the second argument" here

    Deprecation-109548-GeneralUtilityLocationHeaderUrlWithoutRequest.rst:41

    perhaps use "as the second argument" here
  9. Sarah McCarthy uploaded patch set 3 CR +1 V +1 04/18/26, 09:55

  10. Sarah McCarthy commented on patch set 3 04/18/26, 09:56

    Thanks for the review

    Deprecation-109523-GeneralUtilityIsOnCurrentHostWithoutRequest.rst:16 Reply

    Done

    Deprecation-109523-GeneralUtilityIsOnCurrentHostWithoutRequest.rst:40 Reply

    Done

    Deprecation-109544-GeneralUtilitySanitizeLocalUrlWithoutRequest.rst:15 Reply

    Done

    Deprecation-109544-GeneralUtilitySanitizeLocalUrlWithoutRequest.rst:34 Reply

    Done

    Deprecation-109548-GeneralUtilityLocationHeaderUrlWithoutRequest.rst:15 Reply

    Done

    Deprecation-109548-GeneralUtilityLocationHeaderUrlWithoutRequest.rst:34 Reply

    Done

    Deprecation-109548-GeneralUtilityLocationHeaderUrlWithoutRequest.rst:41 Reply

    Done
  11. core-ci voted on patch set 3 V +1 04/18/26, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100452

  12. Chris Müller voted on patch set 3 CR +1 V +1 04/18/26, 17:43

  13. Georg Ringer voted on patch set 3 CR +1 V +1 04/19/26, 05:42

  14. Ines Willenbrock voted on patch set 3 CR +1 V +1 04/19/26, 14:06

  15. Lina Wolf voted on patch set 3 CR +1 V +1 04/19/26, 17:44

  16. Garvin Hicking voted on patch set 3 CR +2 V +2 04/20/26, 05:13

  17. Garvin Hicking merged patch set 4 04/20/26, 05:13