Review 14.3 Merged

93820[BUGFIX] Avoid crash on install tool login warning email

Christian Kuhn CR +2 V +2 Normal +181 −3 updated 04/23/26, 09:11

Commit message

When warning_email_addr is set, the install tool sends a
mail on successful or failed login. The email body is rendered
through FluidEmail against the SystemEmail.fluid.html layout,
which references <core:normalizedUrl> for loginLogo rendering.

The install tool boots a FailsafeContainer.
NormalizedUrlViewHelper got DI with #107537, so
we need to hard-wire in ServiceProvider.

The combination install tool failsafe + fluid + email
broke multiple times already. The patch finally adds
a test showcasing a setup creating a request and feeding
it to ext:install Http/Application.

Also, NormalizedUrlViewHelper gets some tests for
the various URI: / EXT: / bare URL combinations.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 34

  1. Christian Kuhn uploaded patch set 1 04/23/26, 08:56

  2. core-ci voted on patch set 1 V +1 04/23/26, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101010

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 04/23/26, 09:11

  4. Christian Kuhn merged patch set 2 04/23/26, 09:11