Review main Merged

93832[BUGFIX] Fix flaky checkIfCanSortingInlineElement test

Josua Vogel CR +2 V +2 Easy +9 −6 updated 05/02/26, 16:54

Commit message

Use waitForElement and simplify selector.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 913

  1. Josua Vogel uploaded patch set 1 04/23/26, 16:25

  2. core-ci voted on patch set 1 V +1 04/23/26, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101050

  3. Josua Vogel updated the commit message in patch set 2 V +1 04/23/26, 18:18

  4. Josua Vogel updated the commit message in patch set 3 04/23/26, 18:19

  5. core-ci voted on patch set 3 V +1 04/23/26, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101053

  6. core-ci voted on patch set 2 V +1 04/23/26, 18:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101052

  7. Oliver Klee voted on patch set 3 CR +1 V +1 04/23/26, 19:24

  8. Garvin Hicking commented on patch set 3 CR +1 V +1 04/23/26, 19:41

    It's hard to reproduce flakyness for me - ran this 20 times and it didnt fail. But then, I could never locally reproduce the current flakes.
  9. Josua Vogel commented on patch set 3 04/23/26, 19:55

    Reply

    Yes, always gambling :) hope we are lucky
  10. Christian Kuhn updated the commit message in patch set 4 CR +1 V +1 05/02/26, 16:03

  11. Christian Kuhn commented on patch set 4 CR +2 V +2 05/02/26, 16:04

    added v14. let's merge and wait.
  12. core-ci voted on patch set 4 V +1 05/02/26, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101403

  13. Christian Kuhn merged patch set 5 05/02/26, 16:54