Review main Abandoned

93833[BUGFIX] Send cache headers with camino

Georg Ringer CR 0 V 0 Easy +4 −0 updated 08/27/26, 16:46

Commit message

Enable the cache headers.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Georg Ringer uploaded patch set 1 04/23/26, 17:23

  2. Georg Ringer commented on patch set 1 04/23/26, 17:24

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 04/23/26, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101051

  4. Oliver Klee voted on patch set 1 CR +1 04/23/26, 19:25

  5. André Buchmann voted on patch set 1 CR +1 V +1 04/23/26, 20:57

  6. André Buchmann commented on patch set 1 V 0 CR -1 04/23/26, 21:10

    The patch works perfectly, but as I now have read the changelog, I think it's not good to warn about the usage of this config one the one hand and setting it as default in the theme on the other hand: > However, in the past, this could lead to problems, because recurring website users might see outdated content for up to 24 hours (by default) or even longer, even if other website visitors already see new content, depending on various cache_timeout settings. > > Thus, config.sendCacheHeaders = 1 should be used with extreme care. Quoted from: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.3/Feature-104914-UpdatedHTTPHeadersForFrontendRenderingAndNewTypoScriptSettingForProxies.html
  7. Benjamin Franzke commented on patch set 1 CR -1 04/24/26, 06:24

    Reply Unresolved

    ack, `config.sendCacheHeaders` configures client-side caching by default, which we should never do automatically, since the effect is irreversible for those that received the cache instructions. An integrator will need to wait cache-timeout-time until affected users can see changed content.
  8. Oliver Klee voted on patch set 1 CR 0 04/24/26, 12:04

  9. Georg Ringer commented on patch set 2 CR -1 V +1 05/05/26, 02:49

    Published edit on patch set 1.
  10. core-ci voted on patch set 2 V +1 05/05/26, 02:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101513

  11. Georg Ringer abandoned the change 08/27/26, 16:46