Review main Ready for review Stale

93939[BUGFIX] Properly generate loginUrl across site configuration

Moritz Ngo CR 0 V 0 Normal +42 −14 updated 09/11/26, 21:58

Commit message

Prior to this commit, RedirectLoginErrorHandler::handleLoginRedirect()
generated URLs with invalid Hostname because it used the current Site
instead of the target page SiteConfiguration.
This commit now utilizes ContentObjectRenderer to generate the login URL.
First it will try to use the current language. If the URL can't be
generated, the default Language will be used.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 5
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/39/93939/5 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/39/93939/5 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 1

Review log 611

  1. Moritz Ngo uploaded patch set 1 05/04/26, 10:02

  2. Moritz Ngo commented on patch set 1 05/04/26, 10:05

    This change is ready for review.

    RedirectLoginErrorHandler.php:106 Unresolved

    Not sure though, if this is a good idea, to simply set the current language for the target page… The target page's site configuration might not have the language configured, or the page has not been translated. For that I've implemented a fallback to the default language (or no explicit language parameter at all)
  3. core-ci voted on patch set 1 V -1 05/04/26, 10:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101461

  4. Moritz Ngo uploaded patch set 2 V -1 05/05/26, 07:21

  5. core-ci voted on patch set 2 V +1 05/05/26, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101527

  6. Moritz Ngo rebased onto patch set 3 V +1 07/24/26, 14:54

  7. core-ci voted on patch set 3 V +1 07/24/26, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105335

  8. Benni Mack updated the commit message in patch set 4 V +1 09/11/26, 21:46

  9. Benni Mack rebased onto patch set 5 09/11/26, 21:46

  10. core-ci voted on patch set 5 V +1 09/11/26, 21:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108321

  11. core-ci voted on patch set 4 V +1 09/11/26, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108320