Review main Merged

94200[TASK] Add AfterTaskExecutionEvent to EXT:scheduler

Georg Ringer CR +2 V +2 Normal +198 −2 updated 05/30/26, 06:02

Commit message

Dispatches a PSR-14 AfterTaskExecutionEvent in Scheduler::executeTask()
after every task run, including ExecuteSchedulableCommandTask. The event
exposes the task object, a success flag, and the thrown exception (if any)
via getTask(), isSuccess(), and getException().

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1824

  1. Georg Ringer uploaded patch set 1 05/29/26, 06:08

  2. Georg Ringer commented on patch set 1 05/29/26, 06:08

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 05/29/26, 06:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102587

  4. Georg Ringer uploaded patch set 2 V -1 05/29/26, 06:23

  5. core-ci voted on patch set 2 V +1 05/29/26, 06:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102588

  6. Sven Liebert voted on patch set 2 CR +1 V +1 05/29/26, 07:24

  7. Garvin Hicking commented on patch set 2 CR +1 V +1 05/29/26, 07:38

    Fine by me - however, I would also be fine adding this as `@internal` for the v14 backport. I think PSR-14 events, especially if they only carry state and not really logic, are fine to be backported to the current LTS.
  8. Oli Bartsch commented on patch set 2 05/29/26, 09:44

    AfterTaskExecutionEvent.php:24

    ```suggestion * including its success state and any thrown exception. ```

    Index.rst:52

    This does not exist AFAICS
  9. Oli Bartsch commented on patch set 2 05/29/26, 09:46

    SchedulerTest.php:33

    Why no functional test instead of mocking all this stuff?
  10. Georg Ringer uploaded patch set 3 CR +1 V +1 05/29/26, 09:49

  11. Garvin Hicking commented on patch set 3 CR +1 V +1 05/29/26, 09:54

    SchedulerTest.php:33 Reply

    I would argue it saves a bit of instantiation/CI load to let the test focus on this specific code path...
  12. Sven Liebert voted on patch set 3 CR +1 V +1 05/29/26, 09:56

  13. core-ci voted on patch set 3 V -1 05/29/26, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102601

  14. core-ci voted on patch set 3 V +1 05/29/26, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102601

  15. Georg Ringer uploaded patch set 4 CR +1 V +1 05/29/26, 10:12

  16. core-ci voted on patch set 4 V -1 05/29/26, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102603

  17. Georg Ringer uploaded patch set 5 V -1 05/29/26, 10:35

  18. core-ci voted on patch set 5 V +1 05/29/26, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102604

  19. Garvin Hicking voted on patch set 5 CR +1 V +1 05/29/26, 11:32

  20. Sven Liebert voted on patch set 5 CR +1 V +1 05/29/26, 12:14

  21. Oli Bartsch voted on patch set 5 CR +1 V +1 05/29/26, 15:02

  22. Georg Ringer voted on patch set 5 CR +2 V +2 05/30/26, 06:02

  23. Georg Ringer merged patch set 6 05/30/26, 06:02

  24. Georg Ringer commented on patch set 6 05/30/26, 06:02

    AfterTaskExecutionEvent.php:24 Reply

    Done

    Index.rst:52 Reply

    Done

    SchedulerTest.php:33 Reply

    Done