94200[TASK] Add AfterTaskExecutionEvent to EXT:scheduler
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Garvin Hicking +1
- Sven Liebert +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Garvin Hicking +1
- Sven Liebert +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1824
-
Georg Ringer uploaded patch set 1 05/29/26, 06:08
-
Georg Ringer commented on patch set 1 05/29/26, 06:08
This change is ready for review. -
core-ci voted on patch set 1 V -1 05/29/26, 06:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102587
-
Georg Ringer uploaded patch set 2
V -105/29/26, 06:23 -
core-ci voted on patch set 2 V +1 05/29/26, 06:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102588
-
Sven Liebert voted on patch set 2 CR +1 V +1 05/29/26, 07:24
-
Garvin Hicking commented on patch set 2 CR +1 V +1 05/29/26, 07:38
Fine by me - however, I would also be fine adding this as `@internal` for the v14 backport. I think PSR-14 events, especially if they only carry state and not really logic, are fine to be backported to the current LTS. -
Oli Bartsch commented on patch set 2 05/29/26, 09:44
AfterTaskExecutionEvent.php:24```suggestion * including its success state and any thrown exception. ```Index.rst:52This does not exist AFAICS -
Oli Bartsch commented on patch set 2 05/29/26, 09:46
SchedulerTest.php:33Why no functional test instead of mocking all this stuff? -
Georg Ringer uploaded patch set 3
CR +1V +105/29/26, 09:49 -
Garvin Hicking commented on patch set 3 CR +1 V +1 05/29/26, 09:54
SchedulerTest.php:33ReplyI would argue it saves a bit of instantiation/CI load to let the test focus on this specific code path... -
Sven Liebert voted on patch set 3 CR +1 V +1 05/29/26, 09:56
-
core-ci voted on patch set 3 V -1 05/29/26, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102601
-
core-ci voted on patch set 3 V +1 05/29/26, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102601
-
Georg Ringer uploaded patch set 4
CR +1V +105/29/26, 10:12 -
core-ci voted on patch set 4 V -1 05/29/26, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102603
-
Georg Ringer uploaded patch set 5
V -105/29/26, 10:35 -
core-ci voted on patch set 5 V +1 05/29/26, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102604
-
Garvin Hicking voted on patch set 5 CR +1 V +1 05/29/26, 11:32
-
Sven Liebert voted on patch set 5 CR +1 V +1 05/29/26, 12:14
-
Oli Bartsch voted on patch set 5 CR +1 V +1 05/29/26, 15:02
-
Georg Ringer voted on patch set 5 CR +2 V +2 05/30/26, 06:02
-
Georg Ringer merged patch set 6 05/30/26, 06:02
-
Georg Ringer commented on patch set 6 05/30/26, 06:02
AfterTaskExecutionEvent.php:24ReplyDoneIndex.rst:52ReplyDoneSchedulerTest.php:33ReplyDone