94202[TASK] Free EXT:styleguide from hard requirements form/fsc/seo/search
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1012
-
Garvin Hicking uploaded patch set 1 05/29/26, 07:30
-
Garvin Hicking marked it work in progress 05/29/26, 07:33
-
core-ci voted on patch set 1 V +1 05/29/26, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102593
-
Garvin Hicking updated the commit message in patch set 2
V +105/29/26, 07:55 -
Garvin Hicking marked it ready for review 05/29/26, 07:55
-
core-ci voted on patch set 2 V +1 05/29/26, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102594
-
Georg Ringer voted on patch set 2 CR +1 V +1 05/29/26, 08:34
-
Oliver Klee voted on patch set 2 CR +1 05/29/26, 12:26
-
Christian Kuhn commented on patch set 2 CR +1 V +1 06/04/26, 18:15
well, especially with not-loaded fluid_styled_content the FE is kinda useless since no standard element renders: it gives the yellow 'no definition found' box. with fsc loaded, only the pages dedicated to the other extensions fail. this can be acceptable, but it wouldn't hurt to improve the message, or have boxes 'if this does not render, and you want to see it, load some more extensions' ... can be a topic for another change if this is desired. other than that, i clicked around on styleguide for a while and couldn't find further issues. -
Garvin Hicking commented on patch set 2 CR +2 V +2 06/04/26, 18:43
Thanks! I'm merging this now and will look into a possibility here. My main problem with that is that if you later install additional extensions, you'd have to clear the TCA tree to regenerate it with "proper" elements, or with removing the special boxes again. With the current approach, you'll immediately see results once the optional dependencies will be installed. -
Christian Kuhn commented on patch set 2 06/04/26, 18:47
Reply
true. i'm unsure on a good solution on this, too. and i understand your desire to remove the hard dependencies. i rank that with higher priority as well, so let's do it. -
Garvin Hicking merged patch set 3 06/04/26, 18:56