Review main Merged

94202[TASK] Free EXT:styleguide from hard requirements form/fsc/seo/search

Garvin Hicking CR +2 V +2 Easy +9 −7 updated 06/04/26, 18:56

Commit message

For dev setups that want to use EXT:styleguide to showcase features
in a staging or even production deployment, there should be no
hardcoded requirements to optional TYPO3 packages that are not
necessarily needed.

This patch makes them optional, which should gracefully degrade
to the requirements. If the frontend rendering is wanted,
EXT:fluid_styled_content will usually already be a fulfilled
dependency by other extensions (like a sitepackage).

The main reason that EXT:styleguide shipped these dependencies
seemed to only stem from the Site settings, carrying them as
`dependencies` instead of `optionalDependencies`.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Garvin Hicking uploaded patch set 1 05/29/26, 07:30

  2. Garvin Hicking marked it work in progress 05/29/26, 07:33

  3. core-ci voted on patch set 1 V +1 05/29/26, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102593

  4. Garvin Hicking updated the commit message in patch set 2 V +1 05/29/26, 07:55

  5. Garvin Hicking marked it ready for review 05/29/26, 07:55

  6. core-ci voted on patch set 2 V +1 05/29/26, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102594

  7. Georg Ringer voted on patch set 2 CR +1 V +1 05/29/26, 08:34

  8. Oliver Klee voted on patch set 2 CR +1 05/29/26, 12:26

  9. Christian Kuhn commented on patch set 2 CR +1 V +1 06/04/26, 18:15

    well, especially with not-loaded fluid_styled_content the FE is kinda useless since no standard element renders: it gives the yellow 'no definition found' box. with fsc loaded, only the pages dedicated to the other extensions fail. this can be acceptable, but it wouldn't hurt to improve the message, or have boxes 'if this does not render, and you want to see it, load some more extensions' ... can be a topic for another change if this is desired. other than that, i clicked around on styleguide for a while and couldn't find further issues.
  10. Garvin Hicking commented on patch set 2 CR +2 V +2 06/04/26, 18:43

    Thanks! I'm merging this now and will look into a possibility here. My main problem with that is that if you later install additional extensions, you'd have to clear the TCA tree to regenerate it with "proper" elements, or with removing the special boxes again. With the current approach, you'll immediately see results once the optional dependencies will be installed.
  11. Christian Kuhn commented on patch set 2 06/04/26, 18:47

    Reply

    true. i'm unsure on a good solution on this, too. and i understand your desire to remove the hard dependencies. i rank that with higher priority as well, so let's do it.
  12. Garvin Hicking merged patch set 3 06/04/26, 18:56