Review 14.3 Merged

94338[BUGFIX] Respect position "top" in EMU::addTcaSelectItemGroup()

Garvin Hicking CR +2 V +2 Easy +33 −5 updated 06/05/26, 13:43

Commit message

The "referenced group not found" fallback of
ExtensionManagementUtility::addTcaSelectItemGroup() kicks
in unconditionally since the referenced group id is an empty
string when no group is referenced at all. Adding a group
with position "top" is thus rewritten to "bottom" and the
keyword never worked.

The patch fixes this. The test assertion is turned from
assertEquals() into assertSame() since group order matters,
which would have revealed the bug with existing test sets.
They are extended to additionally verify behavior on two
broken setups.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Garvin Hicking commented on patch set 1 06/05/26, 12:50

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/05/26, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103031

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 06/05/26, 13:43

  4. Garvin Hicking merged patch set 2 06/05/26, 13:43