Review 13.4 Merged

94414[SECURITY] Avoid download from fallback storage in FileDownloadController

Oliver Hader CR +2 V +2 Normal +180 −1 updated 06/09/26, 08:59

Commit message

The `FileDownloadController` allows selecting several files
from a given folder for download as zip file. Files for
download are passed with the schema
`<storage-id>:/folder/filename.extension` as POST data to
the controller. The controller retrieves the file from FAL
and provides it as download when the backend user has
access to it. Files or folders in the FAL fallback storage
`0` will currently be resolved, validated for storage
access permissions with `checkFileActionPermission()` and
provided for download if access is granted. This could
lead to download of files with sensitive data like
logfiles.

With this change, downloads of files from the fallback
storage are denied in general for all users. In addition,
functional tests have been added to cover all access
check scenarios of the controller.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 4

Review log 3

  1. Oliver Hader uploaded patch set 1 06/09/26, 08:59

  2. Oliver Hader commented on patch set 1 CR +2 V +2 06/09/26, 08:59

    Auto-approved
  3. Oliver Hader merged patch set 2 06/09/26, 08:59