Review main Merged

94455[TASK] Stabilize media/file-operations e2e test

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 06/10/26, 12:00

Commit message

When run in tile-view mode, the test runs into
a playwright strict mode violation because
multiple `<span>` tags contain the file
name label in this mode.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Benjamin Franzke uploaded patch set 1 06/10/26, 10:12

  2. Christian Kuhn voted on patch set 1 CR +1 06/10/26, 10:26

  3. core-ci voted on patch set 1 V -1 06/10/26, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103302

  4. Benjamin Franzke rebased onto patch set 2 CR +1 V -1 06/10/26, 10:42

  5. Christian Kuhn commented on patch set 2 CR +1 V +1 06/10/26, 10:52

    works. let's bring it in without much further ado when green to unblock the others.
  6. Christian Kuhn commented on patch set 2 06/10/26, 10:54

    Reply

    and commented to wrong patch, but still: this change is fine as well, as soon as the one below is done.
  7. core-ci voted on patch set 2 V +1 06/10/26, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103309

  8. Oliver Klee voted on patch set 2 CR +1 V +1 06/10/26, 11:11

  9. Josua Vogel voted on patch set 2 CR +1 V +1 06/10/26, 11:39

  10. Benjamin Franzke voted on patch set 2 CR +2 V +2 06/10/26, 11:51

  11. Benjamin Franzke merged patch set 3 06/10/26, 12:00