94496[BUGFIX] Improve permission check in Clipboard for root page
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Josef Glatz +1
- Oliver Klee +1
- Oliver Hader +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Josef Glatz +1
- Oliver Hader +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1416
-
Georg Ringer uploaded patch set 1 06/11/26, 15:21
-
Georg Ringer commented on patch set 1 06/11/26, 15:22
This change is ready for review. -
core-ci voted on patch set 1 V +1 06/11/26, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103409
-
Benjamin Franzke commented on patch set 1 06/12/26, 08:06
Clipboard.php:688Hm, this means we allow to insert entires from the root page into the clipboard for all users. I guess we need a `$this->BE_USER->isAdmin() || $schema->getCapability(TcaSchemaCapability::RestrictionRootLevel)->shallIgnoreRootLevelRestriction()` check as in https://github.com/TYPO3/typo3/blob/3897a87c191c7d5bebc4aea425efb18aab8740ec/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L883 The currently if-else structure makes this hard to integrate though, I feel like we need to split this method… -
Garvin Hicking commented on patch set 1 06/12/26, 08:08
Clipboard.php:688ReplyI would aupport splitting, this logic is very hard to grasp also due to inline variable assignment. I tried to read this three times and my brain farts out. -
Benjamin Franzke uploaded patch set 2
V +106/12/26, 08:38 -
Benjamin Franzke commented on patch set 2 06/12/26, 08:38
Clipboard.php:688ReplyDone -
core-ci voted on patch set 2 V +1 06/12/26, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103437
-
Oliver Hader voted on patch set 2 CR +1 06/12/26, 13:49
-
Oliver Hader voted on patch set 2 V +1 06/12/26, 13:56
-
Josef Glatz voted on patch set 2 CR +1 V +1 06/12/26, 17:07
-
Oliver Klee voted on patch set 2 CR +1 06/13/26, 13:44
-
Andreas Kienast commented on patch set 2 06/15/26, 18:31
Clipboard.php:697Unresolvednitpick: int cast is not required here but probably helps for backports, which I consider more important right now. -
Andreas Kienast voted on patch set 2 CR +1 V +1 06/15/26, 18:42
-
Andreas Kienast voted on patch set 2 CR +2 V +2 06/15/26, 18:56
-
Andreas Kienast merged patch set 3 06/15/26, 18:57