Review 14.3 Merged

94504[BUGFIX] Gracefully handle missing packages in TranslationDomainMapper

Benni Mack CR +2 V +2 Easy +13 −1 updated 06/12/26, 15:39

Commit message

The `TranslationDomainMapper::resolveToLegacyFile()` method calls
`findLabelResourcesInPackage()` which throws an
`\InvalidArgumentException` when the referenced extension package
does not exist. This can happen when translation domains reference
uninstalled or non-existent extensions.

Instead of letting the exception bubble up, the domain string is
now returned as-is, which is consistent with the existing fallback
behavior for unknown domains.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Achim Fritz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Achim Fritz +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Benni Mack commented on patch set 1 06/12/26, 10:31

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/12/26, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103441

  3. Achim Fritz voted on patch set 1 CR +1 V +1 06/12/26, 10:51

  4. Benni Mack voted on patch set 1 CR +2 V +2 06/12/26, 15:39

  5. Benni Mack merged patch set 2 06/12/26, 15:39