Review main Merged

948[BUGFIX] fix t3lib_extMgm::addToAllTCAtypes(..... , 'replace:xxx')

Peter Niederlag CR +2 V +1 Easy +43 −1 updated 06/03/13, 20:49

Commit message

t3lib_extMgm::addToAllTCAtypes(..... , 'replace:xxx')
breaks when palette used in many types

Review

  • Code review CR +2
    • Stefan Galinski +2
    • Susi Moog +1
  • Verified V +1
    • Susi Moog +1

Files 2

Review log 16

  1. Peter Niederlag commented on patch set 1 03/01/11, 16:14

    Looks good to me, but someone else must approve looks
  2. Peter Niederlag commented on patch set 1 03/01/11, 16:14

    Looks good to me, approved
  3. Peter Niederlag commented on patch set 1 03/01/11, 16:14

    No score
  4. Peter Niederlag uploaded patch set 2 03/01/11, 16:14

  5. Tolleiv Nietsch commented on patch set 2 03/01/11, 16:14

    (1 inline comment) added comment
    Brilliant change ;)
  6. Susi Moog commented on patch set 1 03/01/11, 16:14

    I would prefer that you didn't submit this
  7. Susi Moog commented on patch set 2 03/01/11, 16:14

    Verified; Looks good to me, but someone else must approve
  8. Steffen Kamper commented on patch set 1 03/01/11, 16:14

    Looks good to me, approved already tested this patch with svn and voted in core list, so go ahead.
  9. Steffen Kamper commented on patch set 2 03/01/11, 16:14

    What's the difference to patchset1, is there a way to see that?
  10. Stefan Galinski commented on patch set 1 03/01/11, 16:14

    Looks good to me, but someone else must approve
  11. Stefan Galinski commented on patch set 2 03/01/11, 16:14

    Looks good to me, but someone else must approve Hi Steffen, Just open a changeset in the side-by-side diff mode and you can define the compare rule (above the options), e.g. to just show the diff between this and the last patch set.
  12. Stefan Galinski commented on patch set 2 03/01/11, 16:14

    Hi Steffen, Just open a changeset in the side-by-side diff mode and you can define the compare rule (above the options), e.g. to just show the diff between this and the last patch set.
  13. Helmut Hummel commented on patch set 1 03/01/11, 16:14

    I would prefer that you didn't submit this Please add a prefix to the commit message
  14. Fabien Udriot commented on patch set 1 03/01/11, 16:14

    I would prefer that you didn't submit this As requested ;)
  15. Stefan Galinski commented on patch set 2 03/01/11, 16:14

    Looks good to me, approved
  16. Stefan Galinski merged patch set 2 03/01/11, 16:14