94882[TASK] Migrate low-level services to Schema API
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Stefan Bürk +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Classes/Imaging/IconRegistry.php4+21 −10
- typo3/sysext/core/Classes/Upgrades/DatabaseRowsUpdateWizard.php+8 −2
- typo3/sysext/core/Classes/ServiceProvider.php+6 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_rowupdater/Classes/Upgrades/RowUpdater/PagesSoftDeleter.phpnew+46 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_rowupdater/Classes/Upgrades/RowUpdater/SysFileHardDeleter.phpnew+46 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_rowupdater/Classes/Upgrades/RowUpdater/TtContentHeaderUpdater.phpnew+45 −0
- typo3/sysext/core/Tests/Functional/Imaging/IconRegistryTest.phpnew+49 −0
- typo3/sysext/core/Tests/Functional/Upgrades/DatabaseRowsUpdateWizardTest.phpnew+75 −0
Review log 1928
Show 23 earlier messages
-
Benni Mack uploaded patch set 1 07/22/26, 11:17
-
core-ci voted on patch set 1 V -1 07/22/26, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105162
-
Benni Mack rebased onto patch set 2
V -107/22/26, 11:44
-
core-ci voted on patch set 2 V -1 07/22/26, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105166
-
Benni Mack uploaded patch set 3
V -108/06/26, 15:43 -
core-ci voted on patch set 3 V +1 08/06/26, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106002
-
Benni Mack updated the commit message in patch set 4
V +108/08/26, 15:15 -
Benni Mack marked it ready for review 08/08/26, 15:15
-
core-ci voted on patch set 4 V +1 08/08/26, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106188
-
Benni Mack updated the commit message in patch set 5
V +108/10/26, 07:42 -
core-ci voted on patch set 5 V -1 08/10/26, 07:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106255
-
Benni Mack rebased onto patch set 6
V -108/10/26, 07:50 -
core-ci voted on patch set 6 V +1 08/10/26, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106256
-
Stefan Bürk commented on patch set 6 08/13/26, 18:23
-
Benni Mack commented on patch set 6 08/14/26, 15:06
let's wait with this change until the conflicting RowUpdater Change is inIconRegistry.php:233ReplyI wonder how we should adapt this comment then? Also: The IconFactory won't be created in install tool, which I think is fine (no TCA icons in Install Tool). -
Benni Mack uploaded patch set 7
V +108/31/26, 22:01 -
core-ci voted on patch set 7 V +1 08/31/26, 22:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107447
-
Benni Mack marked it ready for review 08/31/26, 22:10
-
Benni Mack commented on patch set 7 09/01/26, 06:13
Reply
Done -
Stefan Bürk uploaded patch set 8
V +109/03/26, 08:37 -
Stefan Bürk rebased onto patch set 9 09/03/26, 08:38
-
core-ci voted on patch set 8 V +1 09/03/26, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107728
-
core-ci voted on patch set 9 V +1 09/03/26, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107729
-
Stefan Bürk commented on patch set 9 CR +1 V +1 09/03/26, 08:50
IconRegistry.php:233ReplyI took the liverty to amend directly. This change already waited so long based on that thread (sorry for that!). Patchset 8 carries the follow-up, patchset 9 only and up2date rebase. Basically the docblock on `$tcaSchemaFactory` has been rewritten and now says *why* the argument is optional and the failsafe container has no instance of the TcaSchemaFactory and no icons are there. Further, I reduced the guard to a single guard instead of two and avoided unreachable code in the loop. I also adjusted the `ServiceProvider` comment to match the clear reality today. Tests are sligtly modified/enriched. Regarding my `InstallTool` question for the `IconFactory`, I'll checked it now and to answer my question myself: No. The install controllers get `IconFactory`, `IconRegisrty` and the failsafe `IconViewHelper` injected from the failsafe container. `BootService::makeCurrent()` only swaps the container gehind the `GeneralUtility` instance and already injected instances stay. Hope the changes are fine for you - and take my apology for the long hold on this. -
Oliver Klee voted on patch set 9 V +1 09/03/26, 08:54
-
Georg Ringer voted on patch set 9 CR +2 V +2 09/03/26, 11:20
-
Georg Ringer merged patch set 10 09/03/26, 11:20
IconRegistry.php:233