Review main Merged

94909[TASK] GifBuilder: Remove reference marker for `GdImage` parameters

Andreas Kienast CR +2 V +2 Easy +23 −23 updated 07/24/26, 09:17

Commit message

Methods in the GifBuilder receive instances of `GdImage`, which are
always references by design in PHP. Therefore, the reference markers
(`&`) can be removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Marvin Buchmann +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Marvin Buchmann +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Andreas Kienast uploaded patch set 1 07/23/26, 14:35

  2. core-ci voted on patch set 1 V +1 07/23/26, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105254

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 07/23/26, 18:14

  4. Marvin Buchmann voted on patch set 1 CR +1 V +1 07/24/26, 06:28

  5. Benni Mack voted on patch set 1 CR +1 V +1 07/24/26, 07:15

  6. Andreas Kienast voted on patch set 1 CR +2 V +2 07/24/26, 07:17

  7. Andreas Kienast merged patch set 2 07/24/26, 07:17

  8. Andreas Kienast wrote 07/24/26, 09:17

    Created a revert of this change as Ic880b696c1b2729fcec75885495ae00fb381c678